Repository navigation
Size opaque metadata buffer by checked element count in Mat_VarRead73 - #336
Open
naruto-lgtm wants to merge 3 commits into
Open
naruto-lgtm wants to merge 3 commits into
naruto-lgtm wants to merge 3 commits into
Conversation
Contributor
Author
|
any update? |
tbeu
reviewed
Sep 10, 2026
tbeu
force-pushed
the
mat73-opaque-meta-size
branch
2 times, most recently
from
October 6, 2026 15:44
6550270 to
67ce45c
Compare
Contributor
Author
|
gentle ping |
tbeu
force-pushed
the
mat73-opaque-meta-size
branch
from
October 20, 2026 15:54
67ce45c to
a5ccf61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: read a v7.3 file with an unknown-class integer dataset (classified MAT_C_OPAQUE) whose dataspace element count is near the integer limits.
Cause: the opaque branch sizes the uint32 metadata buffer with a raw
(size_t)nelems * sizeof(mat_uint32_t), but H5Dread fillsnelemselements from the H5S_ALL selection, so the byte multiply wraps (andnelemstruncates on a 32-bit size_t) and H5Dread writes past the allocation.Fix: size the buffer with the overflow-checked
Mulused by the other readers and skip the read when the count would overflow or truncate, keeping the allocation in step with theH5Screate_simpleelement count.