Repository navigation
unit/info-command passes, and fix the readiness probe on a Mac - #2
Merged
Merged
Conversation
Three of three now that yo answers INFO commandstats and reports master_repl_offset, so the file moves into passing.txt and the paragraph about what it was failing becomes a paragraph about what it does not report and why. The runner never got that far on a Mac. It waited for the server with nc -q1 and -q is GNU netcat only, so every probe failed and the script gave up saying yodb never answered. Both netcats read -w as give up after this many seconds, which is what the loop wanted in the first place.
14 of 22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three of three now that yo answers
INFO commandstatsand reportsmaster_repl_offset(tamnd/yo#201), so the file moves intopassing.txtand the paragraph about what it was failing becomes a paragraph about what it does not report and why.The runner never got that far on a Mac. It waited for the server with
nc -q1, and-qis GNU netcat only, so every probe failed and the script gave up saying yodb never answered on the port even though the server was up and had already logged that it was listening. Both netcats read-was give up after this many seconds, which is what the loop wanted in the first place.suite/runtest.shwith no arguments is green on all three files.