ci: spec22-gems msys harness roots the toolchain bin at the msys mount - #114
Merged
Merged
Conversation
The toolchain-bin default spelled the setup-msys2 install root as /d/a/_temp/msys64 — true on the x64 runners, false on windows-11-arm, whose workspace and toolcache live on C:. The third arm64 dogfood (run 35690023046) showed it exactly: the gem-install PATH carried D:\a\_temp\msys64\clangarm64\bin (nonexistent) while make resolved under C:\a\_temp\msys64\usr\bin, so mkmf's recorded clang++ went ENOENT and sassc's objects died with make error 127. The msys2 shell mounts its install root at /, so /<toolchain>/bin resolves the same directory on any drive layout and still rides the conv_envvar conversion into the native spawns. UCRT64_BIN keeps its name and its override contract; only the default changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The third arm64 dogfood (tebako-runtime-ruby run 35690023046) reached the gem-install leg with #112 + #113 in place and died there:
The
UCRT64_BINdefault spelled the setup-msys2 install root as/d/a/_temp/msys64— correct on the x64 runners (workspace on D:), wrong on windows-11-arm (workspace and toolcache on C:). The PATH carried a nonexistentD:\…\clangarm64\bin, so the runtime's recordedclang++could not resolve and sassc's native ext failed with make error 127.What
The default is now
/<toolchain>/bin— POSIX spelling off the msys2 install-root mount./is the install root in the msys2 shell, so the same spelling resolves on any runner drive layout, and it still rides the conv_envvar conversion into native spawns exactly as before. The variable keeps its name and its override contract; only the default changes.Proof
C:\a\_temp\msys64.bash -nclean; no other hardcoded install-root spellings remain (the one left is in the comment documenting this incident)./ucrt64/binresolves to the same directory the old default spelled out on D:-drive runners.