Skip to content

fix(queue): remove unused score import and related assignment in Nack method - #80

Merged
lucasoares merged 1 commit into
takenet:mainfrom
juniorrhis1:fix/issue-79
Sep 18, 2026
Merged

lucasoares merged 1 commit into
takenet:mainfrom
juniorrhis1:fix/issue-79

Conversation

@juniorrhis1

Copy link
Copy Markdown
Collaborator

closes #79

This pull request makes a small change to the internal/queue/queue.go file, specifically related to how message scores are handled when a message is negatively acknowledged (Nack). The main change is the removal of code that directly sets the message score to a minimum value during this process.

  • Removed the dependency on the score package in internal/queue/queue.go.
  • Removed the line that sets msg.Score to score.Min in the Nack method, so the score is no longer forcibly reset when a message is Nacked.

@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.87%. Comparing base (4b13b0a) to head (d7690e5).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   80.88%   80.87%   -0.01%     
==========================================
  Files          27       27              
  Lines        3071     3070       -1     
==========================================
- Hits         2484     2483       -1     
  Misses        418      418              
  Partials      169      169              
Flag Coverage Δ
coverage 80.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Service 80.24% <ø> (ø)
Queue 82.70% <ø> (-0.01%) ⬇️
Audit 83.33% <ø> (ø)
Config 93.05% <ø> (ø)
Command 50.80% <ø> (ø)
Metrics 88.98% <ø> (ø)
Cache 81.39% <ø> (ø)
Storage 79.21% <ø> (ø)
Helpers 61.59% <ø> (ø)
Files with missing lines Coverage Δ
internal/queue/queue.go 92.65% <ø> (-0.03%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b13b0a...d7690e5. Read the comment docs.

@lucasoares
lucasoares merged commit 38ada43 into takenet:main Sep 18, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nack ignores custom score field, always resets to minimum priority

3 participants