Repository navigation
升級 starter 鎖定的套件:astro 7.4.1、@astrojs/language-server 2.17.2,移除 canvaskit-wasm - #204
Merged
Merged
Conversation
…skit-wasm - astro 7.3.1 → 7.4.1(build 的 MODULE_LEVEL_DIRECTIVE 警告消失) - @astrojs/language-server 2.16.13 → 2.17.2(@astrojs/check 0.9.11 原本就巢狀使用 2.17.2,改為單一份) - 移除未使用的 canvaskit-wasm(astro-og-canvas 使用自己的 0.42.0) - 重新解析 vite 為單一份 8.3.4,避免兩份 vite 造成 astro.config.ts 型別錯誤 generated by Claude Code
Contributor
Author
Code Review 結果總結:沒有發現 bug。 這個 PR 也把 #203 遺留的 follow-up 處理掉了,而且驗證特別確實(build 對 build 的差異比對加上 headless 瀏覽器冒煙測試)。CI 已綠(Build + Code standards)。 已驗證項目
備註(不擋 merge)
沒有 merge 前需要處理的問題。 🚩 Generated by OpenCode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
astro、@astrojs/language-server、canvaskit-wasm的版本是 Nimbus starter 帶進來的。最新 starter(templates-v0.7.13)仍鎖在相同版本:astro7.3.1:Nimbus 自身開發用的版本,peer 範圍為>=7.2.6 <8.0.0@astrojs/language-server2.16.13:上游 ae88945f 因 2.17.0 解析錯誤而暫時鎖定canvaskit-wasm^0.41.1:本站程式沒有使用,astro-og-canvas用的是自己巢狀的 0.42.0變更
astro7.3.1 → 7.4.1@astrojs/language-server2.16.13 → 2.17.2。@astrojs/check0.9.11 原本就巢狀使用 2.17.2,這裡改成只留一份。canvaskit-wasmbun.lock:把 vite 統一為 8.3.4。原本 lock 有 8.3.3 和 8.3.4 兩份,會讓astro.config.ts出現Plugin<any>[]型別錯誤。重新解析時,一些間接相依也升了 patch 版本。驗證
lint:text、lint、format:check、typecheck(104 files, 0 errors)、build、lint:docs和nimbus-docs check都通過。MODULE_LEVEL_DIRECTIVE警告消失了。generated by Claude Code