Repository navigation
fix(android): clean permission paths and handle malformed inputs - #83
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Unused Android paths and resources obscure active permission flows. Malformed FCM payloads can throw, and ringtone permission checks return before reaching an Activity while temporary players leak.
What changed
Scope
Blast Radius
Ringtone permission checks are now reachable. Actual permission grant, failed title lookup, player ownership, malformed messages and valid update notifications have regression coverage. The device runners require an explicitly selected disposable emulator.
Verification