Skip to content

refactor(ios): remove unused state and AlarmKit forwarding - #82

Merged
t-regbs merged 3 commits into
mainfrom
codex/cleanup-native
Nov 6, 2026
Merged

t-regbs merged 3 commits into
mainfrom
codex/cleanup-native

Conversation

@t-regbs

@t-regbs t-regbs commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Why

Native code carries unused navigation/audio queries, write-only vibration state and an unread backend flag. Two scheduling methods only forward the same arguments to private implementations.

What changed

  • Remove unused native members and the usedAlarmKit result field.
  • Inline the scheduling and cancellation implementations at their public entry points.

Scope

  • Native structure and generated bridge shape. Alarm scheduling, rollback, recovery, navigation observation and vibration behavior remain intact.
  • Simulator verification does not establish physical-device acoustic or minimum-iOS acceptance.

Blast Radius

The exported result shape changes, so the shared framework and Swift client were rebuilt together. Moved method bodies and protected recovery helpers are byte-identical to the original implementations.

Verification

  • Native branch passes 393 Kotlin tests and 28 Xcode test cases, with one expected iPad-only skip on iPhone; includes live AlarmKit repeated edits/cancellation and fresh-process bridge journeys.
  • Combined cleanup passes 399 Kotlin native tests, fresh framework/header checks, Swift compilation and 28 Xcode cases, with one expected iPad-only skip.
  • Independent review and exact-body checks found no scheduling, callback-order or recovery changes.

@t-regbs
t-regbs merged commit f4e5b34 into main Nov 6, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant