This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Repository navigation
fix(dal): import func arguments during module update and fix PropPath… - #8335
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
aaron-dernley
marked this pull request as ready for review
January 23, 2026 00:30
sprutton1
previously approved these changes
Jan 23, 2026
sprutton1
left a comment
sprutton1
left a comment
Contributor
There was a problem hiding this comment.
Couple of nits, but otherwise lgtm
aaron-dernley
force-pushed
the
fix/dal/import-func-arguments
branch
from
January 23, 2026 13:14
0fcb4e6 to
3a270df
Compare
Contributor
Author
|
Made those changes based on your feedback @sprutton1 - good catches, thank you. |
stack72
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… conversion
Two fixes for module import:
import_funcs_for_module_update was not importing func arguments after creating/updating funcs, causing MissingFuncArgument errors when attribute functions referenced arguments that didn't exist.
create_attr_proto_arg was converting prop_path strings directly via .into() which stored the slash-separated path as a single part. PropPath uses \x0B (vertical tab) as the internal separator, so as_parts() would return the whole path as one element, causing ChildPropNotFoundByName errors. Now properly splits by '/' and constructs PropPath with the parts.
How was it tested?
Does it require a docs change?
In short: 🔗