Repository navigation
Conversation
The reference note shown after a contributor submits was plain text, so a call path or a design tradeoff had to be read out of prose. It may now carry a flow diagram, a comparison table and quoted code, written in a small draft format. Every citation must be a line of the pinned diff, code comes from the diff and is never typed, and a solid arrow needs a citation while an inference is dashed and labeled, so a picture cannot state an unverified claim as fact. Clicking a citation opens its line in the diff. The page draws what the parser returns, with no new dependency, and a note that does not read stays valid as text, which the managed worker relies on. Change-Id: I5887e4eadfadc661446a191d91f472963f21d962
A review can pass every test and still leave debt that no test shows: removed checks nobody can explain, understanding that stayed with one person, and a rationale that was never written down. The workbench now ends with a step that reads the pinned diff and the session as technical, cognitive and intent debt (Storey, arXiv 2603.22106) and asks one question for each. It scores nothing and writes nothing for the contributor. A removed check opens at its old line, and the contributor can write a short intent record in their own words and copy it into the pull request body. The record is kept for one snapshot, is not part of the answers or the signed record, and is never given to the reviewing agent. Change-Id: I65ce7a7bce5e6fc4b9b4976e95037c137c41a99a
Managed mode, the default review, wrote plain prose, so the diagram, table and quoted code were never drawn unless an agent wrote the note by hand. The worker is now taught the draft format, shown the asked file's lines with the numbers a citation uses, and asked for one small flow of the key change unless the change has none. A note the diff does not hold is sent back once with the problem named, then stored as written and shown as text, so a wrong citation never reaches the page as a fact and the worker never loops. Run against the installed Codex CLI it returns a paragraph and a flow whose citations the diff holds. Change-Id: Iaa38ff7f0227a9b6b11e6535e4ee8169f79137b8
Count removed and added assertions on the same basis, so a moved assertion no longer hides a lost one. Finishing now refuses unsaved intent edits as it does unsaved answers. A truncation notice starts its own paragraph so it cannot swallow a closing fence. Load sibling modules once, which makes the note-cache test patch the module the workbench really calls, and run the explainer suite serially because it patches a global. Change-Id: I418aca425f9413edbe50320eda60e9edce5b47f4
The previous commit stacked a second lru_cache on a function that was already cached, which left two caches and made cache_clear reach only the outer one. Its message was also wrong that siblings were loaded on every call; they were already kept. Change-Id: I3ff2b4ae4ea4d6b60fb367eeabe931ffc8ed06d4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interactive review returns a reference note after the contributor submits, and it was plain text: a call path or a design tradeoff had to be read out of prose, and nothing asked who would know the reasons later. The note can now carry a flow diagram, a comparison table and quoted code, and the review gains a step that looks at the change as three kinds of debt.
Every citation in a drawn note must be a line of the pinned diff, and quoted code is taken from the diff, never typed. A solid arrow needs a citation; a link the diff cannot support is drawn dashed and labeled as an inference. When a drawn note cites something the diff does not hold, the reviewer is sent back once with the problem named; if it still does not read, the note is stored as written and shown as plain text.
The debt step gives observations and questions, never a score, and writes nothing for the contributor. A removed check opens at its old line, and the contributor can write a short intent record in their own words and copy it into the PR body. The record is kept for one snapshot, is not part of the answers or the signed record, and is never given to the reviewing agent.
The feedback schema, digest, head binding and completion record are unchanged. The runtime is still the Python standard library and Git, and the new Python modules parse on Python 3.8.
Verified with the review unit suites, the browser suites for the workbench and the flow layout (including a randomized layout property test), and
scripts/test-interactive-review.sh.Demo video:
codetrial-interactive-review-50s.mp4
Summary by cubic
The reference note shown after a contributor submits was plain prose, so a call path or design tradeoff had to be read out of text. This adds drawn reference notes — flow diagrams, comparison tables, and quoted code — plus a debt lens step that reads the change as technical, cognitive, and intent debt.
Draw the reference note
Debt lens and intent record
Written for commit 5b19800. Summary will update on new commits.