Skip to content

[SwiftExtract] Construct .existential for 'any P' types #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kateinoigakukun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SwiftExtract] Construct .existential for 'any P' types #901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SwiftExtract/SwiftTypes/SwiftType.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ extension SwiftType {
if someOrAntType.someOrAnySpecifier.tokenKind == .keyword(.some) {
self = .opaque(try SwiftType(someOrAntType.constraint, lookupContext: lookupContext))
} else {
self = .opaque(try SwiftType(someOrAntType.constraint, lookupContext: lookupContext))
self = .existential(try SwiftType(someOrAntType.constraint, lookupContext: lookupContext))
}

case .compositionType(let compositeType):
Expand Down
33 changes: 33 additions & 0 deletions Tests/SwiftExtractTests/AnalysisResultTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,39 @@ struct AnalysisResultSuite {
#expect(unresolvable.functionSignature.thrownTypedError == nil)
}

@Test
func someAndAnyProduceOpaqueAndExistentialTypes() throws {
let result = try analyze(
sources: [
(
"/fake/Source.swift",
"""
public protocol Swimmer {}
public func trainOpaque(_ swimmer: some Swimmer) {}
public func trainExistential(_ swimmer: any Swimmer) {}
"""
)
],
moduleName: "Aquarium"
)

let byName = Dictionary(uniqueKeysWithValues: result.extractedGlobalFuncs.map { ($0.name, $0) })

let opaque = try #require(byName["trainOpaque"]?.functionSignature.parameters.first?.type)
guard case .opaque = opaque else {
Issue.record("expected .opaque, got \(opaque)")
return
}
#expect(opaque.description == "some Swimmer")

let existential = try #require(byName["trainExistential"]?.functionSignature.parameters.first?.type)
guard case .existential = existential else {
Issue.record("expected .existential, got \(existential)")
return
}
#expect(existential.description == "any Swimmer")
}

@Test
func typedThrowsOnInitializers() throws {
let result = try analyze(
Expand Down
Loading