Repository navigation
fix: scan non-UTF-8 Git diffs without losing text checks - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git can emit malformed UTF-8 fixture bytes as text when a file has no NUL. The source policy previously aborted while decoding those diffs. Decode patch bytes with replacement while retaining strict decoding for Git metadata, so readable added content still receives every policy check.
Validation: 19 tests, generated-workflow consistency and actionlint pass. The real Git fixture covers an invalid byte with clean content and confirms a private path alongside invalid bytes still fails with its line number.