Repository navigation
ci: audit overlapping branch protection - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings audit previously checked rulesets alone, so it missed older branch protection that still locks swift-gyb master and requires an additional approval. swift-codex also retains overlapping legacy checks. Audit the legacy branch-protection endpoint and declare the active rulesets as the single source of enforcement.
Migration verifies each effective default-branch ruleset, its signatures, pull-request rules and required checks before retiring the overlapping legacy rule. Existing rulesets are retained; no administrator merge bypass is used. The Codex legacy checks are already covered by its active ruleset.
Also clarify that the source-policy allowlist retains semantic identifiers such as pagination cursors and CSS keywords.
Validation: 19 behavior tests, workflow derivation, actionlint and whitespace checks pass. The new regression covers a locked legacy branch despite matching rulesets, and distinguishes an explicitly unprotected branch from missing-resource or permission errors. No Swift compilation was run.