fix(postgrest): resolve nullable Value comparisons to mapped columns - #430
Merged
Merged
Conversation
Tr00d
approved these changes
Sep 14, 2026
Tr00d
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Well done, and thanks for your contribution 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #429.
Where(row => row.IntValue.Value > 3)used theNullable<T>.Valuemember name instead of the mapped column:Both comparison paths now use the existing
ResolveColumnhelper, asContainsalready does. URL tests cover direct/cast comparisons, nullable primary keys and a captured-value control. A live PostgREST test verifies that null and nonmatching rows are excluded.Also renames the existing private
ParameterFinder._targetfield totarget: the touched-file format gate flags its old name as IDE1006. No API or behavior change from that rename, and no baseline/dependency changes are included.Validation
Value=gt.3.bash scripts/quality-gate/gate.sh packagesreportsPASS, without--bypass-formator--overwrite-baseline. All 920 tests across eight packages pass with no skips, including live Supabase E2E; the Windows job also passes 147 PostgREST unit/contract tests.The three files in this PR match the verified source exactly. Tests ran on GitHub-hosted runners; validation workflows stay on the fork. Public-API diff: no public surface change. No cross-SDK API/parity change is introduced.
AI-assisted with GitHub Copilot.
Quality gate summary (verbatim)