feat(gotrue): add resend api to request confirmation code - #419
feat(gotrue): add resend api to request confirmation code#419diegofesanto wants to merge 4 commits into
Conversation
Tr00d
left a comment
Tr00d
left a comment
There was a problem hiding this comment.
LGTM
Couple of feedbacks on the structure (move/rename). You did nothing wrong there, but I want the structure to evolve to something more maintainable
| /// additional customization for the resend operation, such as including a CAPTCHA | ||
| /// token or specifying a redirection URL after email confirmation. | ||
| /// </summary> | ||
| public class ResendOptionsParam |
There was a problem hiding this comment.
The naming could be improved. It's called OptionsParam, and the XML doc says optional parameters. There's something off.
I would rename it ResendOptions
| /// <summary> | ||
| /// Parameters for the Resend API. | ||
| /// </summary> | ||
| public class ResendParam |
There was a problem hiding this comment.
I would avoid abbreviations, and use ResendParameters instead
| @@ -0,0 +1,42 @@ | |||
| using System.Text.Json.Serialization; | |||
|
|
|||
| namespace Supabase.Gotrue; | |||
There was a problem hiding this comment.
We're cluttering the root directory Gotrue/.
I want the codebase to evolve towards a UseCase/VerticalSlice structure, and I prefer Resend-specific models to be under a Resend/ folder & namespace.
| @@ -0,0 +1,23 @@ | |||
| using System.Text.Json.Serialization; | |||
|
|
|||
| namespace Supabase.Gotrue; | |||
There was a problem hiding this comment.
We're cluttering the root directory Gotrue/.
I want the codebase to evolve towards a UseCase/VerticalSlice structure, and I prefer Resend-specific models to be under a Resend/ folder & namespace.
| /// <summary> | ||
| /// The type of resend. | ||
| /// </summary> | ||
| public enum ResendType |
There was a problem hiding this comment.
I want the codebase to evolve towards a UseCase/VerticalSlice structure, and I prefer Resend-specific models to be under a Resend/ folder & namespace.
Same for Constants, we could have ResendConstants under Resend/.
2 participants
What kind of change does this PR introduce?
feature
What is the current behavior?
What is the new behavior?
Additional context