Conversation
PostgREST's rule is fixed (GET/HEAD, 503/520, 4 attempts, on/off switch only); Storage's is configurable. Both share full-jitter capped backoff, Retry-After honoured up to the cap, stop on cancellation, and no replay of one-shot bodies or of errors thrown by caller-supplied code. Refs SDK-1791, supabase/supabase-swift#1341. Co-Authored-By: Claude <[email protected]>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds spec files for two existing feature IDs that had none:
database.configuration.auto_retry— the fixed postgrest-js rule: GET/HEAD only, 503/520 only, 4 attempts, a per-client switch and a per-request override of that switch, and nothing else configurable. Full-jitter capped backoff,Retry-Afterhonoured up to the cap, stop on cancellation,X-Retry-Counton replays, and no retry of errors thrown by caller-supplied code.storage.configuration.auto_retry— the configurable counterpart: idempotent methods (or any method with anIdempotency-Key), the transient status set including Cloudflare 520–524/530, a configurable attempt count with1meaning off, and the rule that a one-shot upload body is never replayed.Both describe observable behavior only, per CONTRIBUTING.
npm run validatepasses (OK — capability matrix is valid.).Written alongside the Swift implementation in supabase/supabase-swift#1341, which declares both features implemented in its
sdk-compliance.yaml. Linear: SDK-1791.