Handle empty extended queries - #453
Open
Guflly wants to merge 2 commits into
Open
Conversation
sunng87
reviewed
Aug 7, 2026
| pgwire::api::portal::PortalExecutionState::Initial | ||
| ) { | ||
| let inner_query = &portal.statement.statement; | ||
| let inner_query = portal.statement.statement.as_ref().unwrap(); |
Owner
There was a problem hiding this comment.
can we avoid using a hard unwrap in the examples? try to provide demo for how to handle empty statement
sunng87
reviewed
Aug 7, 2026
| let describe_response = if portal.statement.statement.is_none() { | ||
| DescribePortalResponse::no_data() | ||
| } else { | ||
| self.do_describe_portal(client, &portal).await? |
Owner
There was a problem hiding this comment.
for this api implementation, we will still need to check portal.statement.statement.is_none() or use a hard unwrap just like the examples. I wonder if we can avoid the Option<> in statement, and use a bool field in our Statement struct to indicate if a statement is empty.
WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304.
Empty
Parsemessages now keep an empty statement instead of invoking the query parser.DescribeandExecutereturn the protocol responses expected by PostgreSQL clients, including when handlers override the describe methods.Tests:
cargo test -p pgwirecargo test --test empty_extended_querycargo check -p pgwire --examplescargo check --manifest-path tests-integration/test-server/Cargo.tomlcargo clippy -p pgwire --lib -- -D warnings