Skip to content

fix: ask for champ select's champion lists in each phase, so ranked bans are made - #54

Merged
sunerpy merged 1 commit into
mainfrom
fix/ban-availability
Nov 18, 2026
Merged

sunerpy merged 1 commit into
mainfrom
fix/ban-availability

Conversation

@sunerpy

@sunerpy sunerpy commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

A user's ranked auto-ban never fired: four days of their logs (2026-11-15 to 18) hold no Banned and no failed ban, while the planning intent (Declared) went out each time. winer asked for the pickable and bannable champion lists once a champ select, at its first event, which in ranked is the planning phase, and the ban phase went by those lists. A ban list that is empty or lacks the champion at that point passes over every candidate, and decide coming back empty-handed was silent.

What changes

  • Live.available is keyed by the champ select and its timer phase (ListsFor): each phase asks for the lists again, and an answer for an earlier phase that lands late is dropped (Live::keep_lists).
  • Availability::can_ban takes an empty ban list as no answer, since a ban turn always has champions to ban: the client then has the last word, and a refusal shows as a failed-ban notice instead of nothing.
  • The automation's kind of game falls back on the gameflow session's queue while the catalog does not list the champ select's queue yet (champ_select_mode), so a rule scoped to ranked acts before the catalog has come. The loadout and the callout still read the catalog alone.
  • Debug logs (recorded by default): champion lists with both lists' sizes at each fetch, and nothing to ban on the ban turn once a turn, with the candidates and the ban list's size.
  • docs/platform-notes.md records that what the lists answer in each phase is still not captured.

Not verified on hardware

What bannable-champion-ids answers while planning was not captured: the QA host's client was not running and windows-home refused SSH (2026-11-18). The fix does not depend on it, since the ban phase reads its own lists either way.

Tests

Failing before the change, passing after:

  • service::tests::the_ban_phase_does_not_go_by_the_lists_asked_for_while_planning: planning's lists hold nothing bannable, or a list without the champion; the ban phase tries the ban.
  • automation::tests::a_ban_turn_with_nothing_listed_as_bannable_still_bans
  • service::tests::a_ban_scoped_to_ranked_acts_before_the_catalog_names_the_queue

New: service::tests::a_late_answer_for_an_earlier_phase_is_dropped. Keying the lists by the game alone again fails the first test's second case.

Checks

scripts/evidence.sh green on the final tree (local stamp 20261118T102838Z, tree c6dfb8611e49): lcu 14, winer 52, winer-core 366 tests; shared 7, plugin 72, frontend 174; clippy, fmt, the Windows check, lint, typecheck and format.

BEGIN_COMMIT_OVERRIDE
fix: 修复排位中「自动禁用英雄」不生效:轮到禁用时改按客户端当时允许禁用的英雄来禁,不再沿用规划阶段取到的列表 (#54)

fix: winer 刚连上客户端、还没读到游戏模式信息时,只在部分模式开启的自动选择和自动禁用英雄也能按模式生效 (#54)
END_COMMIT_OVERRIDE

…ans are made

winer asked for the pickable and bannable lists once a champ select, at its
first event (planning, in ranked), and the ban phase went by them: a ban list
empty or without the champion then passed over every candidate in silence.

The lists are now keyed by the champ select and its phase, a late answer for an
earlier phase is dropped, an empty ban list counts as no answer, and the
automation's kind of game falls back on the gameflow session's queue until the
catalog lists it. Debug logs give the lists' sizes and a ban turn that bans
nothing.
@sunerpy
sunerpy merged commit f191373 into main Nov 18, 2026
5 checks passed
@sunerpy
sunerpy deleted the fix/ban-availability branch November 18, 2026 10:40
@winer-release winer-release Bot mentioned this pull request Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant