Repository navigation
feat: complete Godot static-graph reverse edges and add CLI explore/node - #133
Merged
Merged
Conversation
Addresses four gaps reported by the Godot-team liaison doc, all verified
still-broken on 0.28.3 and confirmed static-analysis / tool-consistency
concerns (no WorldFlipper DSL or runtime semantics).
- Signal callbacks: the string-form `X.connect("sig", callback.bind(...))`
now enters callers. `scan_connect` classifies the SECOND argument as the
handler (via the existing connect_handler/split_bind_head/callable_handler),
matching the object-form `.connect(cb.bind())` behavior. No new subkind.
- Resource reverse-impact: `load/preload("res://X.tscn")` resolves to an
imports edge whose node lives on the loader, and .tscn/.tres have no file
node, so `affected`/`audit --impact` missed the loader. resource_impact and
a new dependent_file_paths_via_import_name now also consult imports edges
whose target import node normalizes to the changed resource. Query-side,
golden-neutral, no new subkind.
- Main-scene UID: parse the .tscn `uid="uid://..."` header into a
deterministic uid->path map (sorted, first-write-wins) so
`project.godot run/main_scene="uid://..."` resolves to the scene file and
enters its reverse impact, via the same untagged References path as the
res:// form.
- CLI parity: add `codegraph explore` and `codegraph node` subcommands that
reuse the MCP ExploreSubgraph engine (no fork), so the shell fallback the
tool hint documents actually exists. MCP dispatch and tools/list unchanged.
Golden .schema byte-stability preserved (the shipped godot fixture has no
string-connect / run/main_scene / uid://, so extraction output is unchanged);
equivalence and tools_list goldens untouched.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 95.63% 95.65% +0.01%
==========================================
Files 115 115
Lines 55348 55790 +442
==========================================
+ Hits 52934 53364 +430
- Misses 2414 2426 +12
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the four gaps from the Godot-team liaison doc (rev 25), all verified still-broken on 0.28.3 against a real Godot project, all confirmed static-analysis / tool-consistency concerns (no WorldFlipper DSL or runtime semantics).
X.connect("sig", callback.bind(...))now enterscallers.scan_connectclassifies the SECOND arg as the handler via the existingconnect_handler/split_bind_head/callable_handler(no fork, no new subkind), matching the object-form.connect(cb.bind()).load/preload("res://X.tscn")resolves to an imports edge on the loader, and.tscn/.treshave no file node, soaffected/audit --impact <resource>missed the loader.resource_impact+ a newdependent_file_paths_via_import_namenow also consult imports edges whose target import node normalizes (stripres://) to the changed resource. Query-side, no new subkind, golden-neutral. (The doc's original "add to allow-list" premise was wrong — those refs resolve to edges and leaveunresolved_refs; corrected via first-diagnose.).tscnuid="uid://..."header into a deterministic uid→path map (sorted, first-write-wins);project.godot run/main_scene="uid://..."resolves to the scene file and enters its reverse impact, via the same untaggedReferencespath as theres://form.codegraph exploreandcodegraph nodesubcommands reusing the MCPExploreSubgraphengine (no fork), so the shell fallback the tool hint documents actually exists. MCP dispatch andtools/listunchanged.Verification
make cigreen (fmt + clippy + test + guardrail + equivalence 10/10)..schemabyte-stable — the shipped godot fixture has no string-connect / run/main_scene / uid://, so extraction output is unchanged; no regen. tools_list golden unchanged.Scope: static extraction / query-side reverse-dependency / CLI only. No exclusion-list domains touched.