Skip to content

fix(ci): gate release publish on the tag commit's CI and de-flake reopen test - #131

Merged
sunerpy merged 1 commit into
mainfrom
fix/ci-release-gate-and-flaky-reopen
Jul 10, 2026
Merged

sunerpy merged 1 commit into
mainfrom
fix/ci-release-gate-and-flaky-reopen

Conversation

@sunerpy

@sunerpy sunerpy commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Summary

Two defects surfaced on the v0.28.3 release:

  1. A red CI did not stop the release — ci.yml and release-please.yml are independent push-triggered workflows with no dependency, and build-binaries only runs cargo build (no tests). v0.28.3 published despite a failing CI.
  2. The flaky test that failed that CI (reopens_cached_engine_when_db_replaced_with_new_inode).

Fix 1 — release gate (query-only, parallel)

  • New verify-ci job polls the same tag commit's CI CI Success job via gh api — no cargo re-run (zero duplication of CI's Test job).
  • Runs in parallel with build-binaries (which only emits throwaway retention-days: 1 artifacts and never mutates the Release), so it adds ~0 wall-clock.
  • Gate sits at upload-assets (the first public-facing step): a failed/timed-out verify-ci blocks upload-assets → transitively publish-release, leaving the Release a draft.
  • workflow_dispatch re-attach path = run-and-pass no-op (never skipped, so it can't cascade-skip upload-assets).
  • Adds actions: read permission.

Topology: verify-ci.needs=release-please ∥ build-binaries.needs=release-please → upload-assets.needs=[release-please, build-binaries, verify-ci] → publish-release.needs=[…, upload-assets].

Fix 2 — de-flake reopen test

  • Dropped the brittle assert_ne! on the raw unix inode after delete+rebuild (unix recycles the freed inode; both observed 1343671 under cargo llvm-cov).
  • The #925 contract is the behavioral outcome already asserted (reopen_count +1, new symbol served, no open error) — inode-independent. Companion does_not_reopen_when_inode_is_unchanged unchanged.

Verification

  • make ci green locally.
  • reopen test: 5× plain + 2× under cargo llvm-cov → zero flakes.
  • YAML parses; needs topology confirmed via yaml.safe_load.
  • Independent oracle review: APPROVE (0 blocker/major; gate is fail-closed, no publish path on red CI, no-skip invariant holds).

Scope: test + CI-config only. No extraction/golden/.schema/AI-crate change.

…pen test

Two defects surfaced on v0.28.3: a red CI (a flaky reopen test) did not stop
the release, and the flaky test itself.

Release gate: ci.yml and release-please.yml were independent push-triggered
workflows with no dependency, and build-binaries only runs `cargo build` (no
tests), so a red CI still published. Add a query-only `verify-ci` job that
polls the SAME tag commit's CI `CI Success` job via `gh api` (no test re-run)
and runs IN PARALLEL with build-binaries. The gate sits at `upload-assets`
(the first public-facing step): a failed/timed-out verify-ci blocks
upload-assets and, transitively, publish-release, leaving the Release a draft.
build-binaries only emits throwaway artifacts (retention-days: 1), so running
it in parallel is harmless and saves wall-clock. The workflow_dispatch
re-attach path is a run-and-pass no-op (never skipped, so it cannot
cascade-skip upload-assets). Adds `actions: read` for the gh api reads.

Flaky test: reopens_cached_engine_when_db_replaced_with_new_inode asserted
`assert_ne!` on the raw unix inode after delete+rebuild, but unix recycles the
freed inode (both observed 1343671 under cargo llvm-cov). Drop the brittle
inode assertion; the #925 contract is the behavioral outcome already asserted
(reopen_count advances by exactly one, the new symbol is served, no open
error), which does not depend on inode luck. The companion
does_not_reopen_when_inode_is_unchanged test is unchanged.
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   95.64%   95.63%   -0.01%     
==========================================
  Files         115      115              
  Lines       55334    55348      +14     
==========================================
+ Hits        52923    52934      +11     
- Misses       2411     2414       +3     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sunerpy
sunerpy merged commit 81fcb83 into main Jul 10, 2026
7 checks passed
@sunerpy
sunerpy deleted the fix/ci-release-gate-and-flaky-reopen branch July 10, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant