Skip to content

Sco 2852 drag and drop of blocks - #182

Merged
JannieT merged 43 commits into
mainfrom
sco-2852-drag-and-drop-of-blocks
Aug 27, 2026
Merged

Sco 2852 drag and drop of blocks#182
JannieT merged 43 commits into
mainfrom
sco-2852-drag-and-drop-of-blocks

Conversation

@timosville

Copy link
Copy Markdown
Contributor

No description provided.

@linear-code

linear-code Bot commented Aug 11, 2026

Copy link
Copy Markdown

SCO-2852

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 11, 2026

Copy link
Copy Markdown

Deploying kit with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5ec74bd
Status: ✅  Deploy successful!
Preview URL: https://b31a86b6.kit-atq.pages.dev
Branch Preview URL: https://sco-2852-drag-and-drop-of-bl.kit-atq.pages.dev

View logs

@timosville
timosville marked this pull request as ready for review August 14, 2026 07:11
@timosville
timosville requested a review from JannieT August 14, 2026 07:11
Base automatically changed from sco-2751-refine-studio-colours-brand to main August 18, 2026 08:57

@JannieT JannieT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some refactoring to a make adding a new template easier. Can we address the review comments in the files and these two remaining issues (I think Tim already made a card for the first one):

  1. Native HTML5 drag is on the whole card so dragging from an input can start a reorder. Other reorder dragging in our kit is usually handle-scoped.

  2. BlockImageField / BlockVideoField both write to the Pinia model and emit v-model, while use-chapter-draft-edit also watches blocks and calls model.setField('blocks', …). That is two sources of truth.

Comment thread src/backend/define_config.ts Outdated
Comment thread src/frontend/stories/components/blocks/draft-edit-block-card.vue
Comment thread src/frontend/index.ts
@timosville
timosville requested a review from JannieT August 26, 2026 03:57

@JannieT JannieT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done sir!

@JannieT
JannieT merged commit 174179b into main Aug 27, 2026
2 checks passed
@JannieT
JannieT deleted the sco-2852-drag-and-drop-of-blocks branch August 27, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants