Skip to content

Adaption to changes in storm-dft - #447

Open
volkm wants to merge 1 commit into
stormchecker:masterfrom
volkm:dft-adaption
Open

Adaption to changes in storm-dft#447
volkm wants to merge 1 commit into
stormchecker:masterfrom
volkm:dft-adaption

Conversation

@volkm

@volkm volkm commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Revised includes for storm-dft after changes in stormchecker/storm#1034

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are limited to include refactoring for upstream compatibility and look internally consistent across the affected DFT binding sources.

Pull request overview

This PR updates Stormpy’s DFT pybind bindings to align with upstream storm-dft header/API reshuffling (per storm PR stormchecker/storm#1034), mainly by replacing umbrella/internal includes with the new dedicated storm-dft/api/* headers and adding a few newly-required concrete includes.

Changes:

  • Replace removed/changed storm-dft umbrella includes with more specific storm-dft/api/* includes.
  • Add missing storm-dft and Storm adapter includes needed after the upstream header refactor.
  • Remove now-redundant local include(s) where the new headers cover the required declarations.
File summaries
File Description
src/mod_dft.cpp Adds a Storm rational function forward header needed for typed binding instantiations.
src/dft/transformations.cpp Drops a redundant local include after upstream header changes.
src/dft/simulator.cpp Removes obsolete storm-dft umbrella include and redundant local include.
src/dft/module.cpp Adds explicit storm-dft/storage/DFT.h include and removes redundant local include.
src/dft/io.cpp Switches from local helpers include to the new storm-dft/api/io.h.
src/dft/dft.cpp Adds RelevantEvents include required by updated storm-dft structure.
src/dft/dft_state.cpp Adds explicit DFT / dependency headers needed with the new storm-dft include layout.
src/dft/dft_elements.cpp Removes redundant local include after upstream header changes.
src/dft/common.h Removes the old storm-dft umbrella include from the shared DFT header.
src/dft/analysis.cpp Includes new storm-dft API headers for analysis and transformation entry points.
Review details
  • Files reviewed: 10/10 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants