Adaption to changes in storm-dft - #447
Open
volkm wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to include refactoring for upstream compatibility and look internally consistent across the affected DFT binding sources.
Pull request overview
This PR updates Stormpy’s DFT pybind bindings to align with upstream storm-dft header/API reshuffling (per storm PR stormchecker/storm#1034), mainly by replacing umbrella/internal includes with the new dedicated storm-dft/api/* headers and adding a few newly-required concrete includes.
Changes:
- Replace removed/changed
storm-dftumbrella includes with more specificstorm-dft/api/*includes. - Add missing
storm-dftand Storm adapter includes needed after the upstream header refactor. - Remove now-redundant local include(s) where the new headers cover the required declarations.
File summaries
| File | Description |
|---|---|
| src/mod_dft.cpp | Adds a Storm rational function forward header needed for typed binding instantiations. |
| src/dft/transformations.cpp | Drops a redundant local include after upstream header changes. |
| src/dft/simulator.cpp | Removes obsolete storm-dft umbrella include and redundant local include. |
| src/dft/module.cpp | Adds explicit storm-dft/storage/DFT.h include and removes redundant local include. |
| src/dft/io.cpp | Switches from local helpers include to the new storm-dft/api/io.h. |
| src/dft/dft.cpp | Adds RelevantEvents include required by updated storm-dft structure. |
| src/dft/dft_state.cpp | Adds explicit DFT / dependency headers needed with the new storm-dft include layout. |
| src/dft/dft_elements.cpp | Removes redundant local include after upstream header changes. |
| src/dft/common.h | Removes the old storm-dft umbrella include from the shared DFT header. |
| src/dft/analysis.cpp | Includes new storm-dft API headers for analysis and transformation entry points. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revised includes for storm-dft after changes in stormchecker/storm#1034