Repository navigation
Update comments to reflect the last-used timestamp granularity - #429
Merged
Merged
Conversation
Since #428, last-used timestamps are only accurate to within `LAST_USED_GRANULARITY`, and `touch_image` skips updating recent ones. Link both comments to the constant with Tagref so they stay in sync. Also reword the comment before the "Waking up" log line, which claimed a vacuum was about to happen even though vacuums only happen for new images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #428, last-used timestamps are only accurate to within
LAST_USED_GRANULARITY, andtouch_imageskips updating recent ones. This PR updates the comments onstate::Image::last_used_since_epochandtouch_imageaccordingly, linking both to the constant with a new[tag:last_used_granularity]so Tagref keeps them in sync.It also rewords the comment before the "Waking up" log line, which said a vacuum was about to happen even though vacuums only happen when a new image comes in.
This PR only changes comments, so there's no version bump.
Status: Ready
Fixes: N/A