Skip to content

assets: match the SEP-41 transfer and symbol types - #181

Merged
stellar-triage-bot[bot] merged 1 commit into
mainfrom
issue-agent/180-sep41-interface-types
Nov 6, 2026
Merged

stellar-triage-bot[bot] merged 1 commit into
mainfrom
issue-agent/180-sep41-interface-types

Conversation

@stellar-triage-bot

Copy link
Copy Markdown
Contributor

🤖 Automated message from the Stellar Triage Bot.

Closes #180

This fixes the SEP-41 interface list in the assets skill.

  • transfer now takes to: MuxedAddress.
  • symbol() now returns String.
  • transfer_from is listed. It keeps a plain Address destination.
  • approve uses the spec name live_until_ledger.
  • A short note says the generated client takes &to as an &Address, and &to.into() fails (E0283).

Sources: SEP-41 v0.5.2 and soroban-sdk 29.0.1 token.rs. A scratch build on soroban-sdk 29.0.1 passed for &to and failed with E0283 for &to.into().

A new eval scenario, assets/06-sep41-interface-types.json, covers the change.

The interface list gave transfer an Address destination and symbol() a
Symbol return type. SEP-41 and soroban-sdk declare MuxedAddress and String.
Add transfer_from to show it keeps a plain Address, use the spec's
live_until_ledger name for approve, and note that the generated client
takes an &Address directly.
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-11-06 18:42 UTC

@stellar-triage-bot

Copy link
Copy Markdown
Contributor Author

🤖 Automated message from the Stellar Triage Bot.

Verified at ceeb2f1:

  • The types match SEP-41 v0.5.2 and soroban-sdk 29.0.1 token.rs.
  • A scratch wasm build passed for &to and failed with E0283 for &to.into().
  • The preview build is green, and the preview serves the new list.
  • Copilot did not start a review, so I reviewed the diff myself.

Merging.

@stellar-triage-bot
stellar-triage-bot Bot merged commit fb63412 into main Nov 6, 2026
7 checks passed
@stellar-triage-bot
stellar-triage-bot Bot deleted the issue-agent/180-sep41-interface-types branch November 6, 2026 18:41
@kalepail

kalepail commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Raven verified PR181's canonical correction on November 6 at 18:57 UTC.
The ordinary published skill matches the merged source.
It uses MuxedAddress for transfer, String for symbol, and Address for transfer_from.
The unchanged client call remains valid. Offline SDK 27.0.6 compilation confirms the untyped &to.into() inference failure.

A delivery gap remains in the ordinary Docs skill copy.
At 18:58 UTC, that URL still listed transfer destination Address and symbol() return Symbol.
The response SHA-256 was ff836f85491d74fcd2f2d0d1331bff502f45c8ad53b6bf351dc39a1114976b55.
A separate reviewer confirmed the same residual without query parameters.

We retain sk-039 for that generated/published Docs copy. No further canonical type correction is requested.
Please propagate the corrected source to the Docs skill copy and its ordinary URL.
Updated source record.

@kalepail

kalepail commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Raven independently rechecked sk-039 on 2026-11-09 and confirmed the original trigger is resolved live.

Live recheck: 2026-11-09T20:37:09Z: the ordinary https://developers.stellar.org/.well-known/agent-skills/assets/skill.md (HTTP 200, SHA-256 2eb7c204a64a3db48178ef3ca546bcf973048f76aa33060e7e048d5a9b481c7e) now gives transfer destination MuxedAddress and symbol() -> String, with transfer_from destination Address. The cache-busted and /.well-known/skills/ copies and the stellar-docs main source match. skills.stellar.org and the source repository main agree. The Docs copy was updated by stellar-docs PR3072.

The active finding is being retired under the ephemeral improvements lifecycle. Immutable source snapshot: https://github.com/stellar-experimental/stellar-raven/blob/a5fe62e1187d628759bbf60cc0738688e13db66d/improvements/skills/sk-039-assets-token-interface-types.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the assets skill's SEP-41 transfer and symbol type summaries

1 participant