Skip to content

assets: qualify issuer lockout in the custom SAC admin guidance - #178

Merged
stellar-triage-bot[bot] merged 1 commit into
mainfrom
issue-agent/177-issuer-lock-signers
Nov 6, 2026
Merged

stellar-triage-bot[bot] merged 1 commit into
mainfrom
issue-agent/177-issuer-lock-signers

Conversation

@stellar-triage-bot

Copy link
Copy Markdown
Contributor

🤖 Automated message from the Stellar Triage Bot.

Closes #177

Master key weight 0 disables only the master key. Other signers can still issue the asset or restore the master key. This PR applies the signer condition from "Lock Issuing Account" to the places that still said "master key weight 0" alone:

  • skills/assets/SKILL.md: the custom SAC admin prerequisite, the set_admin-first warning, and the security checklist.
  • skills/cross-chain/layerzero.md: the issuer lock note.
  • evals/scenarios/assets/04-sac-admin-handover.json: expected behavior now requires a complete lock.

Sources:

  • Control asset access: other signers meeting medium can issue; high can restore the master key.
  • List of operations: Set Trustline Flags needs only the low threshold.
  • rs-soroban-env account_contract.rs: Soroban auth for a classic account sums all signer weights against the medium threshold. So a remaining signer can also authorize set_admin.

USDT0's issuer has master weight 0 and no other signers, so the "USDT0's issuer is locked" line stays.

Master key weight 0 disables only the master key. Other signers that
meet the medium threshold can still issue, and high-threshold signers
can restore the master key. Apply the fixed-supply section's signer
condition to the custom-admin prerequisite, the handover warning, the
security checklist, the LayerZero note and the handover eval.
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-11-06 02:22 UTC

@stellar-triage-bot

Copy link
Copy Markdown
Contributor Author

🤖 Automated message from the Stellar Triage Bot.

Verified at f230e26:

  • Each changed claim matches Control asset access, List of operations, and account_contract.rs (medium threshold over all signers).
  • USDT0 issuer on Horizon: master weight 0, no other signers.
  • preview build passed. Eval JSON is valid.
  • Copilot did not start a review after the request.

Merging.

@stellar-triage-bot
stellar-triage-bot Bot merged commit 9817057 into main Nov 6, 2026
7 checks passed
@stellar-triage-bot
stellar-triage-bot Bot deleted the issue-agent/177-issuer-lock-signers branch November 6, 2026 02:21
@kalepail

kalepail commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Raven rechecked the ordinary Docs assets skill on November 6 at 18:58 UTC.
The prerequisite, handover warning and security checklist now account for other signers and their thresholds.
The canonical published skill also retains these corrections. A separate reviewer repeated both live checks.

The original signer-control defect is resolved, including its previously stale delivery path. We are retiring sk-038.
The separate interface-type delivery gap remains tracked as sk-039; it does not reopen this signer-control finding.
Immutable source record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Qualify issuer lockout in the assets skill's custom SAC admin guidance

1 participant