Repository navigation
build(deps): refresh stabilized workspace dependencies - #576
Conversation
Consolidate the six updates proposed in #575 with eligible provider, parser, media, browser-test, and transitive fixes. Preserve the seven-day cooldown, Node 24 floor, security overrides, and adm-zip patch. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 847644c471
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| '@emnapi/core': 2.0.0-beta.2 | ||
| '@emnapi/runtime': 2.0.0-beta.2 |
There was a problem hiding this comment.
Exclude newly introduced Emnapi prereleases
The Rolldown WASM binding now resolves both @emnapi/core and @emnapi/runtime to 2.0.0-beta.2, although neither prerelease was present in the parent lockfile. This violates the dependency policy in AGENTS.md, which excludes prereleases unless already adopted; passing the seven-day publication-age check does not satisfy that restriction. Keep these resolutions on compatible stable releases, or hold the dependency update that introduces them.
AGENTS.md reference: AGENTS.md:L19-L19
Useful? React with 👍 / 👎.
Refresh stabilized workspace dependencies, incorporating all six updates from #575 plus eligible sanitize-html, MediaBunny, Playwright, lint-helper, transitive, and security-override updates. All 165 newly resolved package versions meet the seven-day stabilization policy. Node 24, application versions, pnpm, and the adm-zip patch remain unchanged.
The updated ICU parser exposed an ambiguous elapsed-time skeleton:
unit/duration-secondnow reaches JavaScript as an invalid unit name. Use the explicit ICUmeasure-unit/duration-secondform in all 14 catalogs to retain existing formatting. Add all-locale rendering coverage and document the supported syntax.Validation: the new regression cases first failed in all 14 locales; all 39 focused localization/sidepanel tests then passed. Full
pnpm run checkpassed on AWS Crabbox: 605 test files and 3,923 tests passed, with the existing 49 live/optional tests skipped. Extension build passed; pnpm audit reports zero vulnerabilities. Independent Codex P0–P2 reviews are clean. GitHub CI covers macOS release builds/Rosetta and Chromium/Firefox extension paths.Supersedes #575 and preserves Dependabot coauthor credit. Bilibili and browser-slides policy holds remain untouched.