Skip to content

build(deps): refresh stabilized runtime and browser tooling - #573

Merged
steipete merged 1 commit into
mainfrom
maintenance/round20-deps
Nov 14, 2026
Merged

steipete merged 1 commit into
mainfrom
maintenance/round20-deps

Conversation

@steipete

@steipete steipete commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Refresh stabilized provider, HTTP, media, Preact, Playwright, and Oxc/test dependencies. This includes every update from #569 and newer eligible patch/minor versions selected from npm publication timestamps.

The seven-day adoption hold, Node 24 minimum, pnpm version, and security overrides remain unchanged. No project version bump or release is included.

Validation: lockfile generation and supply-chain policy checks pass; independent Codex P0–P2 autoreview is clean. Full Linux Node 24 build/check passed: 605 test files, 3,909 tests, 49 skipped, 94.52% line coverage and 85.67% branches. The rebased source tree is identical to the tested tree. Exact-head GitHub CI is required before merge.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

CI hold (2026-11-14 07:28 UTC): all checks except macos-release-build passed. The required xcode-27 job is still queued after eight bounded status checks over 35 minutes. This PR is ready for the remaining platform proof; it has not been merged.

Update provider, HTTP, media, Preact, Playwright and Oxc/test dependencies after the seven-day hold. Keep Node 24, pnpm, and all security overrides unchanged. Incorporates and extends #569.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@clawsweeper

clawsweeper Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T06:52:31.189217Z 36163cd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Nov 14, 2026
@clawsweeper

clawsweeper Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codex review: needs changes before merge.

What this changes

Updates stabilized runtime, browser, and development dependencies across the CLI, core library, and extension.

Example: Install the workspace using pnpm install --frozen-lockfile.

  • Before: Core declares linkedom ^0.18.13 and installs 0.18.13.
  • After: Core declares linkedom ^0.18.15 but still installs 0.18.13 through the workspace override and unchanged lockfile.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) Useful maintenance supported by registry verification and automated integration coverage, with one narrow manifest-to-lockfile inconsistency requiring repair.
Proof confidence 🦐 gold shrimp (3/6) This maintainer-authored dependency maintenance PR is outside the contributor proof gate; existing Linux and browser CI provides automated integration coverage.
Patch quality 🦐 gold shrimp (3/6) 1 actionable review finding remain.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Partial
User problem: Older dependencies miss upstream provider, media, rendering, and tooling improvements.
Reason: The owner-authorized refresh follows established maintenance policy, although the promised incorporation of the linked dependency update is incomplete.

Merge readiness

⛔ Needs changes before merge - 1 item remains

Keep this maintainer-authored PR open: the dependency refresh is useful, but its LinkeDOM manifest update is missing from the lockfile.

Priority: P3
Reviewed head: 36163cd9fa44abcebb6a3902b7407586375aba09

Before merge

  • Resolve the declared LinkeDOM update in the lockfile (P2) - Raising this requirement to ^0.18.15 does not update workspace installs: pnpm-lock.yaml still selects 0.18.13 for core and WXT because the workspace override permits it. Consequently, frozen-install CI exercises the older parser while the published core manifest requires the newer line, and the LinkeDOM update from build(deps): bump the dependencies group with 10 updates #569 has not actually been incorporated. Update the lockfile resolutions and associated dependency records so validation covers the intended version.

Findings

  • [P2] Resolve the declared LinkeDOM update in the lockfile — packages/core/package.json:97
Agent review details

How this fits together

Workspace manifests and the lockfile select libraries used by the CLI, extraction core, daemon, and browser extension to turn content into summaries and media results.

flowchart TD
  A[Package manifests] --> B[Dependency lockfile]
  B --> C[CLI and daemon]
  B --> D[Core extraction]
  B --> E[Browser extension]
  C --> F[User results]
  D --> F
  E --> F
Loading

Technical review

Best possible solution:

Resolve the intended LinkeDOM update in the existing lockfile while preserving the stabilization hold, security overrides, and current application behavior.

Do we have a high-confidence way to reproduce the issue?

The manifest, workspace override, and lockfile directly establish that frozen workspace installs retain LinkeDOM 0.18.13; no target code or tests were run.

Is this the best way to solve the issue?

Updating the existing lockfile is the smallest complete repair and makes workspace validation exercise the dependency now required by the published core manifest.

Full review comments:

  • [P2] Resolve the declared LinkeDOM update in the lockfile — packages/core/package.json:97
    Raising this requirement to ^0.18.15 does not update workspace installs: pnpm-lock.yaml still selects 0.18.13 for core and WXT because the workspace override permits it. Consequently, frozen-install CI exercises the older parser while the published core manifest requires the newer line, and the LinkeDOM update from build(deps): bump the dependencies group with 10 updates #569 has not actually been incorporated. Update the lockfile resolutions and associated dependency records so validation covers the intended version.
    Confidence: 0.99

Overall correctness: patch is incorrect
Overall confidence: 0.96

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 937657c257cf.

Provenance checked

Testing

Proof path: in-process harness.

Security

None.

Evidence

Acceptance criteria:

  • pnpm install --frozen-lockfile
  • pnpm run build
  • pnpm run check
  • pnpm -C apps/chrome-extension build
  • pnpm -C apps/chrome-extension test:chrome

What I checked:

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Review metrics

Metric Value Why it matters
New package resolutions verified 90 of 90 All newly resolved versions satisfy the seven-day hold and match registry integrity metadata.

Labels

Label changes:

  • add P3: Routine dependency maintenance with a narrow lockfile omission and no demonstrated urgent user regression.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🦐 gold shrimp.
  • add status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action.

Label justifications:

  • P3: Routine dependency maintenance with a narrow lockfile omission and no demonstrated urgent user regression.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🦐 gold shrimp.
  • status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 14, 2026, 2:04 AM ET / 07:04 UTC.

@steipete
steipete merged commit 29898ea into main Nov 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant