Repository navigation
chore(deps): refresh Go patch and build tooling - #8
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: blocked before merge. Reviewed September 4, 2026, 6:23 AM ET / 10:23 UTC. ClawSweeper reviewWhat this changesThe PR updates the preferred Go toolchain to 1.26.8, aligns the Docker builder and frontend, and refreshes pnpm to 12.2.1 with its lockfile. Merge readiness⛔ Blocked before merge - 3 items remain Keep open for explicit owner review: the introduced update is internally consistent and has no actionable correctness or security finding, but this owner-authored PR is not eligible for automated cleanup. Priority: P3 Review scores
Verification
How this fits togetherblucli is a Go command-line client for BluOS devices. Build metadata selects the Go compiler, package helper, and container environment that produce the CLI binary in CI and releases. flowchart LR
A[Source code] --> B[Go toolchain selection]
C[Package helper] --> D[Build helpers]
B --> D
D --> E[Docker build]
D --> F[CLI binary]
E --> G[Container image]
Decision needed
Why: Repository policy keeps owner-authored work open for explicit maintainer handling, and the supplied check state still has the macOS job queued. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Land the aligned version refresh after explicit owner approval and successful completion of the queued macOS test. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR changes build and package tooling rather than addressing a runtime bug report. Is this the best way to solve the issue? Yes: updating the shared Go directive, Docker argument, pnpm declaration, and regenerated lockfile keeps all declared build entrypoints aligned without changing source compatibility. AGENTS.md: found, but no applicable review policy affected this item. Codex review notes: model internal, reasoning high; reviewed against f6722d81355a. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Refresh the preferred Go toolchain from 1.26.6 to 1.26.8 and align the Docker builder. Keep the Go 1.25.0 source minimum and macOS 12 compatibility; Go 1.27 would raise the macOS floor. Update the Dockerfile frontend to 1.27 and pnpm to 12.2.1 with its regenerated lockfile.
pnpm 12.3.1 was evaluated but deferred: the existing pnpm 11.24.0 launcher attempts to run its native executable through Node. Version 12.2.1 works through that launcher and passes frozen installation and the repository helpers. Go library dependencies, Action major versions, and Alpine 3.24 are already current.
Validation:
No release or application behavior changes.