Repository navigation
Play audio sources without a position unspatialized, so stereo clips keep their channels - #729
Merged
Merged
Conversation
…keep their channels
|
📦 Development package |
|
✅ Development package validation passed on all platforms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #728
AudioSource.Positionis now aVector3?that defaults to null. Null passes NULL toMIX_SetTrack3DPosition, so SDL_mixer plays the clip unspatialized, with its own channels. Any position,Vector3.Zeroincluded, spatializes the track and mixes it down to mono.AudioListener.Positionre-applies only the sources that have a position.AudioSystemTestsread the track position back from SDL_mixer. A source without a position stays at the origin while the listener moves, and setting a position and then null reaches the track.Pixely.Audioexposes internals toPixely.Testsfor this.The y-only position change that SDL_mixer 3.2.4 ignores is tracked in stanoddly/XDL#36.