Repository navigation
docs: the shape of a change is part of the bar - #333
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.md gains a "Shape of a change" section after the quality audit of 2026-10-21.
The audit found the hygiene rules hold (no inline comments, no mocks, seams respected, gates honest) while the codebase accretes faster than it consolidates: main code +43% and tests +82% in six weeks at a 2.5:1 add-to-delete ratio (6.5:1 in store+sync); facades that absorb every verb (SailOperations 66 → 88 public methods, FdeCommand 713 → 1,728 lines, a 275-line ServerStartCommand.execute); four liveness compensators over one gap; run status as string literals in six lifecycle classes; two-phase construction behind 42 null guards; 71 hand-written toMap bodies; 13 private ShellExec fakes.
The section names each of those shapes as a finding for the build agent, the reviewer, the fix agent and the merge, so the same bar applies at every step. It adds one rule to "Working a spec": the pull request body states what the change deleted.
Consolidation itself is six draft specs: sail-stores-share-one-journal, sail-api-one-constructor-one-encoder, sail-run-ends-through-one-finish, sail-one-provisioning-pipeline, sail-test-support-shared, sail-v1-drop-migrations.