Repository navigation
rooms: a live member is shown working for the whole of its turn, and a reply that lands unseen is on the pill - #133
Merged
Conversation
…a reply that lands unseen is on the pill
…unts only what the reader has not seen
…es, and the typing row stays for a reader who is away
…o a turn's beginning is tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec:
mast-live-room-member. Closes what #132 left short of it. Sail's side is standardapplied/sail#310.What was wrong
What changed
agent_turn_began(sail#310) joins the live event types and opens the turn's draft with nothing in it. It rides the same list as the other three, so it is on the room stream'stype=query and in the telemetry and non-record sets with no further change.TypingRowand the draft share oneTypingDots.repliesUnseen), unless it was already drawn before they left. A turn behind the pill counts once it has written something.agent_turn_began.Against a box without sail#310
No
agent_turn_beganarrives, so the wait before the first text or tool step of a later turn is as it was. Everything else here works: the dots under an open draft, and the pill. Sail 0.47 ignores a name it does not know intype=.Release order
Mast before sail. A Mast without this change treats
agent_turn_beganon the app-wide stream as an unknown type and refreshes the room once per turn. The same holds today for the released pair: Mast 0.1.96 does not know sail 0.47's three live types (#132 taught it), so it refreshes on every delta of a live turn until 0.1.97 ships.Verification
bun run typecheck,bun test(1,394 pass, 0 fail),bun run build:tauri-web; CIverifygreen.Small things left, in draft
mast-draft-yields-to-its-own-reply