Repository navigation
Conversation
Read native scene bytes on every access and memoize only matching successful decodes. Preserve binding transactions and fall back to the declared default when decoding fails. BREAKING CHANGE: CodableSceneStorage value and binding access require the main actor. Decode failures return the declared default rather than a prior successful value.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fc897a022
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Include reference-payload and nonisolated initialization checks in every fixture build. Clarify that root swift test does not run the standalone scene application.
There was a problem hiding this comment.
🟡 Changes recommended
Successful assignments can retain stale reference values, and the transaction-test helper lacks a required availability annotation.
2 open issues
What changed in this PR
Updates Codable scene storage to consult native bytes on every read while caching successful decodes. AppStorage behavior remains unchanged.
Changes:
- Adds a scene-local cache and transaction-preserving bindings.
- Adds unit tests and installed-scene regression fixtures.
- Documents actor access, fallback behavior and storage limitations.
| File | Description |
|---|---|
| Tests/SwiftStorageTests/CodableStorageTests.swift | Removes unhosted scene-storage assertions. |
| Tests/SwiftStorageTests/CodableSceneStorageTests.swift | Tests caching, failures and transactions. |
| Tests/Fixtures/SceneStorageProbe/Sources/SceneStorageProbe/Probe.swift | Adds peer/native coherence scenarios. |
| Tests/Fixtures/SceneStorageProbe/Sources/SceneStorageProbe/LifecycleProbe.swift | Exercises cache lifetime and dynamic keys. |
| Tests/Fixtures/SceneStorageProbe/Sources/SceneStorageProbe/HostingAndRestoration.swift | Checks hosting and restoration parity. |
| Tests/Fixtures/SceneStorageProbe/Sources/SceneStorageProbe/FullProbe.swift | Coordinates extended and multiscene checks. |
| Tests/Fixtures/SceneStorageProbe/Sources/SceneStorageProbe/FailureProbe.swift | Checks failures and JSON formats. |
| Tests/Fixtures/SceneStorageProbe/Sources/SceneStorageProbe/APIForms.swift | Provides public API compile coverage. |
| Tests/Fixtures/SceneStorageProbe/run_probe.sh | Launches the Python runner. |
| Tests/Fixtures/SceneStorageProbe/run_probe.py | Builds, launches and records fixture results. |
| Tests/Fixtures/SceneStorageProbe/README.md | Documents fixture execution and scope. |
| Tests/Fixtures/SceneStorageProbe/Package.swift | Defines the standalone fixture package. |
| Sources/SwiftStorage/CodableStorage.swift | Removes the previous scene-storage implementation. |
| Sources/SwiftStorage/CodableSceneStorage.swift | Implements native-byte reads and decode caching. |
| README.md | Documents updated scene-storage semantics. |
Review effort: Balanced
After a local write,
SceneStorage.Codablecould keep returning its cached value after a peer wrapper or native scene-storage writer changed the bytes. Read native Data on every property and binding access, and reuse only successful decodes whose key and complete bytes still match.Keep the memo in a local StateObject without publishing cache mutations. Successful assignments clear the local decoded memo even when bytes are unchanged. Bindings forward their transaction. Invalid JSON returns the declared default; encoding failures preserve both stored bytes and the memo and emit a fixed diagnostic. Standard JSON null remains distinct from a missing value.
Compatibility
Value and projected-binding access now require the main actor. Initializers, JSON encoding, typed-key identity and deployment declarations retain their existing forms. Reference results may retain identity between reads; assignment is required to persist mutations. AppStorage behavior is unchanged.
Validation
swift test --build-system nativepassed 94 tests across 15 suites using Swift 6.4.2, including regression coverage for successful same-byte reference reassignment and rejected-write cache preservation. The new reassignment test failed before the fix.APIForms.swift. Rootswift testdoes not build or launch this nested app; its build/runner is separate.README documents actor access, fallback/write errors, JSON null, reference caching, key identity and native hosting limitations. The standalone fixture README documents its runtime suites and reproduction commands.