Skip to content

[fix] Update service slug mapping for Business Login and add TaurusDB - #409

Merged
Aloento merged 1 commit into
mainfrom
fix
Oct 6, 2026
Merged

Aloento merged 1 commit into
mainfrom
fix

Conversation

@Aloento

@Aloento Aloento commented Oct 6, 2026

Copy link
Copy Markdown
Member

No description provided.

@ecosquad-autoreview ecosquad-autoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Small PR that (a) updates src/Components/Home/serviceSlugMap.json — renaming the MyWorkplace key to Business Login / MyWorkplace and adding a new TaurusDB: "taurusdb" entry — and (b) bumps two dev dependencies (@vitejs/plugin-react 6.1.1 → 6.1.2, postcss 8.5.28 → 8.5.29) with a matching lockfile update.

I traced the only consumer, src/Components/Home/ServiceItem.tsx (getServiceUrl), which does an exact in serviceSlugMap lookup and then either returns http… values verbatim or prepends https://docs.otc.t-systems.com/ for slug values. Both new entries follow those existing patterns, so they resolve correctly:

  • Business Login / MyWorkplace → https://myworkplace.t-systems.com/MyWorkplace/Login.aspx (returns verbatim)
  • TaurusDB → https://docs.otc.t-systems.com/taurusdb

No bugs, security issues, or performance concerns. CI: GitGuardian passed; the JS/Actions analysis and check runs were still in-flight at review time.

Findings

suggestion — confirm the service name matches the new key
src/Components/Home/serviceSlugMap.json:18 — the rename from MyWorkplace to Business Login / MyWorkplace only works if the dashboard's status-data feed reports the service under exactly that display name. The lookup is an exact match (serviceName in serviceSlugMap), so if the feed still emits MyWorkplace, that service's link will silently fall back to the generic slug logic (https://docs.otc.t-systems.com/myworkplace) instead of the MyWorkplace login URL. Worth confirming against the source data before merging. Not a code defect, just an assumption about external data that I can't verify from the diff.

suggestion — dependency bumps look routine
@vitejs/plugin-react and postcss are patch-level dev-dependency bumps; the lockfile propagation (to @stencil/core and peer-dependency resolution) is internally consistent. No action needed.

Verdict

Approve — the change is correct as written; the only open item is confirming the data feed's service name matches the renamed key.

@Aloento
Aloento merged commit c829c5b into main Oct 6, 2026
7 checks passed
@Aloento
Aloento deleted the fix branch October 6, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant