Skip to content

fix(objectstorage): check service enablement only if service call fails#1479

Open
SerseusWasTaken wants to merge 1 commit into
mainfrom
fix/object-storage-check-service-enablement-adjustment
Open

fix(objectstorage): check service enablement only if service call fails#1479
SerseusWasTaken wants to merge 1 commit into
mainfrom
fix/object-storage-check-service-enablement-adjustment

Conversation

@SerseusWasTaken

@SerseusWasTaken SerseusWasTaken commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

Changes CLI behavior to only check if the object-storage service is available in the given project if the initial service call fails.
Also added service enablement checks to list and create commands that were missing them.

relates to STACKITCLI-426

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@SerseusWasTaken
SerseusWasTaken requested a review from a team as a code owner July 16, 2026 11:40
@SerseusWasTaken
SerseusWasTaken force-pushed the fix/object-storage-check-service-enablement-adjustment branch from 56f1003 to bc8bc1b Compare July 16, 2026 12:10
@github-actions

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/create 41.67% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/list 38.89% (-3.97%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/describe 53.85% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/lock 35.71% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/unlock 27.03% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials-group/create 50.00% (-6.76%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials-group/list 56.25% (-6.54%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials/create 53.57% (-5.25%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials/list 55.93% (-5.18%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/create/create.go 41.67% (ø) 48 20 28
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/list/list.go 38.89% (-3.97%) 54 (+5) 21 33 (+5) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/describe/describe.go 53.85% (ø) 39 21 18
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/lock/lock.go 35.71% (ø) 42 15 27
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/compliance-lock/unlock/unlock.go 27.03% (ø) 37 10 27
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials-group/create/create.go 50.00% (-6.76%) 42 (+5) 21 21 (+5) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials-group/list/list.go 56.25% (-6.54%) 48 (+5) 27 21 (+5) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials/create/create.go 53.57% (-5.25%) 56 (+5) 30 26 (+5) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials/list/list.go 55.93% (-5.18%) 59 (+5) 33 26 (+5) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant