Repository navigation
test(proc): cut the stopGroup race test to 50 iterations - #19
Merged
Merged
Conversation
Without the kill fix it came with, the test fails within its first three iterations in every run: the first or second natively, and the second or third under QEMU, where the first is slow while QEMU translates the code. At 50 it still fails without the fix in 3 of 3 runs, under QEMU and natively, and with it the test takes half as long: about 0.65 s instead of 1.4 s under QEMU, and 0.05 to 0.1 s instead of 0.1 to 0.2 s natively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
stopGrouprace test that came with the kill fix now makes 50 calls instead of 100. Without the fix it fails within its first three calls in every run, so 50 calls still fail 3 runs out of 3, natively and under QEMU. With the fix the test takes half as long under QEMU, about 0.7 s instead of 1.4 s. A misc fragment records the change.