Repository navigation
docs(rfc9162): a root is the lower-case hex that hex writes - #9
Merged
Merged
Conversation
Head.root was documented as hex and the verify functions' roots not at all, but both verify functions compare the root they recompute with the given text as hex writes it, and from_hex refuses anything but 0-9 and a-f. An upper-case root verified nothing with no word why. Lower case stays the one form, since Head::material signs the root as text and a second spelling would be a second signed form of one head; the docs of Head.root and both verify functions now say so, and the reference page says lowercase. The code was right, so there is no failing test; a test pins that an upper-case root fails inclusion and both consistency paths. The verify_consistency doc named its path parameter nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Head.root,verify_inclusionandverify_consistencynow say that a root is the lower-case hexhexwrites.Head.rootwas documented as hex and the verify functions' roots not at all, but both verify functions compare the root they recompute with the given text ashexwrites it, andfrom_hexrefuses anything but 0-9 and a-f. An upper-case root verified nothing with no word why.Head::materialsigns the root as text and a second spelling would be a second signed form of one head. The docs ofHead.rootand both verify functions now say so, and the reference page says lowercase. Theverify_consistencydoc named its path parameternodes; that is fixed too.The branch has a towncrier fragment.