Repository navigation
fix(shard): count -f as forcing a rebuild - #52
Merged
Merged
Conversation
-f is EasyBuild's short form of --force, and shard_sources already takes it as the one short option it models, but parse_lines counts only --rebuild and --force as forcing a line. A build list that rebuilds installed CMake with -f and then builds Szip, which needs CMake, gets two shards: the CMake line builds nothing and weighs 0, and Szip lands in another shard that can build while eb -f rebuilds CMake under it. With --force the plan is one shard with CMake first. Both tests fail: parse_lines gives [true, true, false, false] for --rebuild, --force, -f and --hooks=-f, and stack shard prints shards=2 for the -f list.
parse_lines now takes -f, EasyBuild's short form of --force, as it takes --force and --rebuild: the line's own module counts as not installed. With -f uncounted, an installed module the line rebuilds was left out of every closure, so it weighed nothing, the line it belongs to was planned as building nothing, and a line that needs the module could go to another shard and build while eb -f rebuilt it. The stack shard reference names -f, and llms-full.txt follows it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-fis EasyBuild's short form of--force, butparse_linescounted only--rebuildand--forceas forcing a line. A build list that rebuilds an installed CMake with-fand then builds Szip got two shards, so Szip could build whileeb -frebuilt CMake under it. With--forcethe same list plans one shard with CMake first.parse_linesnow treats-flike--force. The first commit adds the failing tests (parse flags and astack shardcount), and the second makes them pass. Thestack shardreference andllms-full.txtname-f.