Repository navigation
fix(solve): keep a dependency's stated versionsuffix - #46
Merged
Merged
Conversation
The profile solve built every direct requirement with versionsuffix
None, while the missing-dependency check matched the stated suffix. A
dependency the check found satisfied could then lock another build of
the same version: the provider ranks builds by version and then suffix,
so the last suffix in string order won. package bump of a GCCcore-15.2.0
recipe depending on ('HDF5', '1.14.2', '-mpi'), against a tree with the
plain, -mpi and -serial HDF5 1.14.2 builds, locked
HDF5-1.14.2-GCCcore-15.2.0-serial.eb and rewrote the tuple to '-serial'.
('HDF5', '1.14.2', '') went the same way.
The requirement now carries the stated suffix when a candidate the solve
can take has it, with the name, version requirement and toolchain the
check uses. Otherwise the suffix is left open as before, so across a
generation -CUDA-12.9.1 still takes the -CUDA-13.3.0 build when the
target carries only that one, and the bump_workflow test for it passes
unchanged.
A profile_emission test solves the plan directly and a bump_workflow
test runs the bump. Both fail without the fix. bump-recipe.org states
the rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package bumpandpackage plankeep a dependency's stated versionsuffix when the robot tree has a build with it that the solve can take.('HDF5', '1.14.2', '-mpi')and('HDF5', '1.14.2', '')became the-serialbuild because that one ranks higher. The solve now takes another suffix only when the target has no build with the stated one, as when-CUDA-12.9.1moves to-CUDA-13.3.0across a generation.a_bump_keeps_the_stated_versionsuffix_variantanda_dependency_versionsuffix_selects_that_variantcover those. The commit has a towncrier fragment. Main has no towncrier yet; #26 (fix/towncrier) adds it.