Skip to content

fix(solve): keep a dependency's stated versionsuffix - #46

Merged
HaoZeke merged 1 commit into
mainfrom
fix/solve-versionsuffix
Nov 16, 2026
Merged

HaoZeke merged 1 commit into
mainfrom
fix/solve-versionsuffix

Conversation

@HaoZeke

@HaoZeke HaoZeke commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

package bump and package plan keep a dependency's stated versionsuffix when the robot tree has a build with it that the solve can take.

  • ('HDF5', '1.14.2', '-mpi') and ('HDF5', '1.14.2', '') became the -serial build because that one ranks higher. The solve now takes another suffix only when the target has no build with the stated one, as when -CUDA-12.9.1 moves to -CUDA-13.3.0 across a generation.

a_bump_keeps_the_stated_versionsuffix_variant and a_dependency_versionsuffix_selects_that_variant cover those. The commit has a towncrier fragment. Main has no towncrier yet; #26 (fix/towncrier) adds it.

The profile solve built every direct requirement with versionsuffix
None, while the missing-dependency check matched the stated suffix. A
dependency the check found satisfied could then lock another build of
the same version: the provider ranks builds by version and then suffix,
so the last suffix in string order won. package bump of a GCCcore-15.2.0
recipe depending on ('HDF5', '1.14.2', '-mpi'), against a tree with the
plain, -mpi and -serial HDF5 1.14.2 builds, locked
HDF5-1.14.2-GCCcore-15.2.0-serial.eb and rewrote the tuple to '-serial'.
('HDF5', '1.14.2', '') went the same way.

The requirement now carries the stated suffix when a candidate the solve
can take has it, with the name, version requirement and toolchain the
check uses. Otherwise the suffix is left open as before, so across a
generation -CUDA-12.9.1 still takes the -CUDA-13.3.0 build when the
target carries only that one, and the bump_workflow test for it passes
unchanged.

A profile_emission test solves the plan directly and a bump_workflow
test runs the bump. Both fail without the fix. bump-recipe.org states
the rule.
@HaoZeke
HaoZeke merged commit c612b15 into main Nov 16, 2026
21 checks passed
@HaoZeke
HaoZeke deleted the fix/solve-versionsuffix branch November 16, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant