Skip to content

fix(package): drop the space runs in wrapped messages - #43

Merged
HaoZeke merged 1 commit into
mainfrom
fix/residual-spacing
Nov 16, 2026
Merged

HaoZeke merged 1 commit into
mainfrom
fix/residual-spacing

Conversation

@HaoZeke

@HaoZeke HaoZeke commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Wrapped residual messages no longer carry a run of spaces where the source line was wrapped, including the source finding in src/artifact_class.rs.

  • The package plan residuals for an inferred moduleclass and for a dropped build requirement, and the source finding for a tree that declares no version, read as one sentence.

residual_summaries_read_as_one_sentence covers that. The commit has a towncrier fragment. Main has no towncrier yet; #26 (fix/towncrier) adds it.

Three messages were wrapped by moving the end of the line into the
string, indentation included. package plan wrote "moduleclass tools is
inferred from the package's own classifiers;              this tree
carries no other recipe for beautifulsoup4 to take it from" and "binutils
is a stated build requirement and this tree carries no module for it,
                 so the recipe does not name it" into package.plan.json
and the residual table. The source finding for a tree that declares no
version had the same gap after "the recipe version".

The three strings now continue with a backslash. A unit test in
package_workflow.rs runs the two residual passes on the bs4 PyPI
fixture, and the unverified-version test in artifact_class.rs checks the
whole message. Both fail without the fix.
@HaoZeke
HaoZeke merged commit 2c8dfbf into main Nov 16, 2026
21 checks passed
@HaoZeke
HaoZeke deleted the fix/residual-spacing branch November 16, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant