Repository navigation
fix(component-reach): resolve the closure over the whole tree - #41
Merged
Merged
Conversation
component-reach handed rebuild_set only the recipes of the generation. The gfbf and gompi hierarchies are read off their toolchain definition recipes, which are SYSTEM recipes and so outside the generation, so no unpinned dependency of a recipe on gfbf-2026.1 or gompi-2026.1 resolved. Those requirements went to rebuild_set's unresolved list, which component-reach dropped: for curl, R/4.6.1-gfbf-2026.1 and netCDF/4.10.0-gompi-2026.1 had no closure rows and nothing said so. The closure now resolves over every recipe in the trees. The roots and the installed set keep its rows in the generation. Requirements that still resolve to nothing are listed in a new closure_unresolved field of the JSON and TOML documents, omitted when empty, as rebuild-set lists them in its own unresolved field. On easybuild-easyconfigs develop with the EESSI 2026.06 easystack, curl's closure gains 19 dependents on gfbf-2026.1 and gompi-2026.1 and 12 recipes only they pull in, and the counts go from review=106 no-rebuild=16 to review=133 no-rebuild=20. The how-to quotes the new line. Two tests in tests/component_reach.rs cover the gfbf and gompi dependents and the unresolved list; both fail without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
component-reachresolves the closure over every recipe in the trees, so dependents ongfbfandgompitoolchains of the generation are in it.gfbf-2026.1andgompi-2026.1, such as R, netCDF, HDF5 and SciPy-bundle, and 12 recipes only they pull in. Requirements no recipe resolves are listed inclosure_unresolvedinstead of being dropped.dependents_on_every_toolchain_of_the_generation_are_in_the_closureanda_dependency_the_closure_cannot_resolve_is_listedcover those. The commit has a towncrier fragment. Main has no towncrier yet; #26 (fix/towncrier) adds it.