Skip to content

fix(component-reach): resolve the closure over the whole tree - #41

Merged
HaoZeke merged 1 commit into
mainfrom
fix/component-reach-generation
Nov 16, 2026
Merged

HaoZeke merged 1 commit into
mainfrom
fix/component-reach-generation

Conversation

@HaoZeke

@HaoZeke HaoZeke commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

component-reach resolves the closure over every recipe in the trees, so dependents on gfbf and gompi toolchains of the generation are in it.

  • The closure missed dependents that live only on those toolchains. On easybuild-easyconfigs develop with the EESSI 2026.06 easystack, curl's closure gains 19 dependents on gfbf-2026.1 and gompi-2026.1, such as R, netCDF, HDF5 and SciPy-bundle, and 12 recipes only they pull in. Requirements no recipe resolves are listed in closure_unresolved instead of being dropped.

dependents_on_every_toolchain_of_the_generation_are_in_the_closure and a_dependency_the_closure_cannot_resolve_is_listed cover those. The commit has a towncrier fragment. Main has no towncrier yet; #26 (fix/towncrier) adds it.

component-reach handed rebuild_set only the recipes of the generation.
The gfbf and gompi hierarchies are read off their toolchain definition
recipes, which are SYSTEM recipes and so outside the generation, so no
unpinned dependency of a recipe on gfbf-2026.1 or gompi-2026.1
resolved. Those requirements went to rebuild_set's unresolved list,
which component-reach dropped: for curl, R/4.6.1-gfbf-2026.1 and
netCDF/4.10.0-gompi-2026.1 had no closure rows and nothing said so.

The closure now resolves over every recipe in the trees. The roots and
the installed set keep its rows in the generation. Requirements that
still resolve to nothing are listed in a new closure_unresolved field
of the JSON and TOML documents, omitted when empty, as rebuild-set
lists them in its own unresolved field.

On easybuild-easyconfigs develop with the EESSI 2026.06 easystack,
curl's closure gains 19 dependents on gfbf-2026.1 and gompi-2026.1 and
12 recipes only they pull in, and the counts go from review=106
no-rebuild=16 to review=133 no-rebuild=20. The how-to quotes the new
line. Two tests in tests/component_reach.rs cover the gfbf and gompi
dependents and the unresolved list; both fail without the fix.
@HaoZeke
HaoZeke merged commit 6a403f5 into main Nov 16, 2026
21 checks passed
@HaoZeke
HaoZeke deleted the fix/component-reach-generation branch November 16, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant