Skip to content

fix(version): compare D[D]MonYYYY versions by date - #39

Merged
HaoZeke merged 1 commit into
mainfrom
fix/date-versions
Nov 16, 2026
Merged

HaoZeke merged 1 commit into
mainfrom
fix/date-versions

Conversation

@HaoZeke

@HaoZeke HaoZeke commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

D[D]MonYYYY versions compare by date, so LAMMPS 22Jul2025_update4 ranks after 29Aug2024.

  • cmp_version tokenized those left to right, so the day of the month decided first: 29Aug2024 sorted after 22Jul2025_update4, and 22Jul2025_update4 sorted before 22Jul2025. stack gap then named LAMMPS-29Aug2024-foss-2023b-kokkos.eb as the newest recipe outside generation 2026.1, though EasyBuild 5.4.2 has 22Jul2025_update4.
  • parse_version_parts now reads a leading D[D]MonYYYY date as year, month and day, and an update right after it as its number. Requirements such as >=29Aug2024 compare the same way. LAMMPS is the only package in easybuild-easyconfigs with such versions. Every other version tokenizes as before.

the_newest_date_version_elsewhere_is_the_latest_release and date_versions_order_by_release_date_then_update cover those. This branch and fix/gap-bump-source both add tests at the same spot in src/gap.rs; keep both. Merged with the other thirteen in this batch, the suite is 1940 passed, 0 failed, 10 ignored (1912 on main). The commit has a towncrier fragment. Main has no towncrier yet; #26 (fix/towncrier) adds it.

LAMMPS names releases by date, 29Aug2024 or 22Jul2025_update4.
cmp_version tokenized those left to right, so the day of the month
decided first: 29Aug2024 sorted after 22Jul2025_update4, and
22Jul2025_update4 sorted before 22Jul2025 because a letter sorts before
a number. stack gap then named LAMMPS-29Aug2024-foss-2023b-kokkos.eb as
the newest recipe outside generation 2026.1, though EasyBuild 5.4.2 has
22Jul2025_update4.

parse_version_parts now reads a leading D[D]MonYYYY date as year,
month, and day, and an `update` right after it as its number, so the
seven LAMMPS versions in easybuild-easyconfigs sort by release and
stable update. LAMMPS is the only package there with such versions.
Every other version tokenizes as before.

On the EESSI 2026.06 site list from the deck demo, the stack gap
output changes only in the LAMMPS row, which now names
LAMMPS-22Jul2025_update4-foss-2025a-kokkos.eb. Unit tests in version.rs
and gap.rs cover the order, a requirement, and the gap row; both fail
without the fix.
@HaoZeke
HaoZeke merged commit 9eafbe1 into main Nov 16, 2026
21 checks passed
@HaoZeke
HaoZeke deleted the fix/date-versions branch November 16, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant