Repository navigation
fix(target): put the attempt's module tree on MODULEPATH for verification - #38
Merged
Merged
Conversation
…tion
A campaign attempt builds with --installpath set to its own prefix,
<work_root>/install-attempts/<package>-<version>/attempt-<N>, and that
flag takes precedence over the prefix EESSI-extend derives from
EESSI_USER_INSTALL. Nothing put the prefix's module tree on MODULEPATH,
so a verification command such as the examples'
`module load {module} && ...` could not find the module the attempt had
just built. On EESSI 2026.06, natsort's verification failed with Lmod's
"The following module(s) are unknown"; with this change the same
campaign completes and natsort is binary-verified.
verification_command now runs the command through a short sh wrapper on
the target that puts the module tree first on MODULEPATH and on
EESSI_EXTRA_MODULEPATH, extending the values there. The EESSI init
replaces MODULEPATH and keeps EESSI_EXTRA_MODULEPATH, after its own
trees. The tree follows EasyBuild's install_path('mod'):
EASYBUILD_INSTALLPATH_MODULES, or the install path and
EASYBUILD_SUBDIR_MODULES, then EASYBUILD_SUFFIX_MODULES_PATH, by
default <installpath>/modules/all. Without EASYBUILD_INSTALLPATH the
command is unchanged.
The target reference, the campaign run reference, and the eOn on EESSI
how-to now say where attempts install, and the how-to no longer says
the modules land under $EESSI_USER_INSTALL. A campaign test with a fake
eb and a target test of the routed command cover the module tree, with
and without an EESSI-style MODULEPATH reset; both fail without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A verification command runs with the attempt's module tree first on
MODULEPATH. The docs say each attempt's--installpathtakes precedence over the prefix EESSI-extend derives fromEESSI_USER_INSTALL.--installpathset to its own prefix,<work_root>/install-attempts/<package>-<version>/attempt-<N>. Nothing put the prefix's module tree onMODULEPATH, so a verification command such asmodule load {module} && ...could not find the module the attempt had just built. On EESSI 2026.06, natsort's verification failed with Lmod's "The following module(s) are unknown".verification_commandnow runs the command through a short sh wrapper on the target that puts the module tree first onMODULEPATHand onEESSI_EXTRA_MODULEPATH. The EESSI init replacesMODULEPATHand keepsEESSI_EXTRA_MODULEPATH. The tree follows EasyBuild'sinstall_path('mod'), by default<installpath>/modules/all. WithoutEASYBUILD_INSTALLPATHthe command is unchanged. The target reference, the campaign run reference, and the eOn on EESSI how-to now say where attempts install.a_verification_command_loads_the_module_the_attempt_installedandverification_command_puts_the_installed_module_tree_firstcover those. The commit has a towncrier fragment. Main has no towncrier yet; #26 (fix/towncrier) adds it.