Skip to content

fix(campaign): classify verification failures as sanity - #37

Merged
HaoZeke merged 1 commit into
mainfrom
fix/verify-findings
Nov 16, 2026
Merged

HaoZeke merged 1 commit into
mainfrom
fix/verify-findings

Conversation

@HaoZeke

@HaoZeke HaoZeke commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

A failed verification command is a sanity finding, or timeout, and findings no longer print Rust debug text such as exit Some(1).

  • A profile verification command that failed with an Lmod error: line was classed as compile, because the generic error: test came before the verify-stage fallback to sanity. reference/campaigns.org maps a failed verification command to sanity. After the target-side classes (transport, executor, resource, runtime) and the robot classes, a verify-stage failure is now timeout or sanity.
  • The finding summary printed the exit code as exit Some(1), and history lines named the class as Compile or DependencyMissing, where the state file says compile and dependency-missing. BuildFindingClass now displays as its serde name, and the verification summary uses the exit-status text the build summary already used.

a_failed_verification_command_is_a_sanity_finding, a_failed_verification_finding_reads_the_way_the_state_file_spells_it and a_failed_build_names_its_class_the_way_the_state_file_does cover those. The commit has a towncrier fragment. Main has no towncrier yet; #26 (fix/towncrier) adds it.

A profile verification command that failed with an Lmod "error:" line
was classed as compile, because the generic "error:" test came before
the verify-stage fallback to sanity, which was never reached.
reference/campaigns.org maps a failed verification command to sanity.
Nothing is fetched, patched, configured, compiled, linked or installed
while a verification command runs, so after the target-side classes
(transport, executor, resource, runtime) and the robot classes a
verify-stage failure is now timeout or sanity.

The finding summary printed the exit code with Rust debug formatting,
"exit Some(1)", and every history line named the class the same way,
"as Compile" or "as DependencyMissing", where the state file says
"compile" and "dependency-missing". BuildFindingClass now displays as
its serde name, and the verification summary uses the exit-status text
the build summary already used.

Tests: the classifier on recorded Lmod and Python output for the verify
stage, and campaigns whose verification command or EasyBuild command
fails, checked for class, summary and history wording.
@HaoZeke
HaoZeke merged commit 961b956 into main Nov 16, 2026
21 checks passed
@HaoZeke
HaoZeke deleted the fix/verify-findings branch November 16, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant