Skip to content

fix(cargo): quote CC and LIBRARY_PATH in the EESSI prelude - #31

Merged
HaoZeke merged 3 commits into
mainfrom
fix/cargo-prelude-quoting
Nov 16, 2026
Merged

HaoZeke merged 3 commits into
mainfrom
fix/cargo-prelude-quoting

Conversation

@HaoZeke

@HaoZeke HaoZeke commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

The cargo-on-EESSI prelude quotes CC and LIBRARY_PATH.

  • LINKER=${CC:-gcc} and an eval of CARGO_TARGET_*_LINKER=${CC:-gcc} reparsed the value, so a CC that held more than a linker was run. LIBRARY_PATH was expanded the same way. The prelude now defaults an empty CC to gcc, exports LINKER="$CC", restricts the target triple to a variable name, and walks LIBRARY_PATH as data. The howto and CLI reference match that.

eessi_cargo_isolation_does_not_run_a_command_hidden_in_cc runs the prelude with a CC that would print a marker if it were executed, and checks the marker is absent. The pypi/CRAN extend fixture checks the quoted form. The commit has a towncrier fragment.

@HaoZeke
HaoZeke force-pushed the fix/cargo-prelude-quoting branch from 9ad96aa to ab64bfa Compare November 16, 2026 07:13
HaoZeke added a commit that referenced this pull request Nov 16, 2026
The rebased #34, "feat(target): run the EESSI target through eb-local",
on top of #31.

The Cargo prelude in src/cargo.rs keeps both: #31's CC default, quoted
LINKER, filtered triple and quoted eval, inside #34's chained triple read
(`_triple= && if ...; fi &&`). The inline comment that cited
scripts/eessi-extend-eb.sh goes, as in #34, which deletes that script and
moves the best-effort note to the function's doc comment.
HaoZeke added a commit that referenced this pull request Nov 16, 2026
The rebased #40, "fix(gap): choose the bump source by toolchain family and
generation", on top of #31 and #34.
@HaoZeke
HaoZeke merged commit 684b75d into main Nov 16, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant