Repository navigation
fix: decide whether a line is a staged rebuild before it builds - #30
Merged
Merged
Conversation
The build loop asked is_staged() after the build had run. A rebuild line whose module file was missing ran as plain eb, as the run log warned, but the build installed the module file, so the result file noted that the line ran through eb-staged-rebuild. Had that build failed with exit 2 or 75, its code went through map_staged and the line and the run were reported refused (78) or pending. The loop now asks once, before the build, as build_cmd does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build loop asked
is_staged()after the build had run. A rebuild line whose module file was missing ran as plaineb, as the run log warned, but the build installed the module file, so the result file noted that the line ran through eb-staged-rebuild. Had that build failed with exit 2 or 75, its code went throughmap_stagedand the line and the run were reported refused (78) or pending.The loop now asks once, before the build, as
build_cmddoes.