Repository navigation
build: run the suite and differential steps in the build root - #16
Merged
Merged
Conversation
Both steps run their script by a path relative to the working directory, tests/test_eb_keep_logs.sh and tests/differential.sh, and a Run step without a cwd runs where zig build was started. zig build finds build.zig in a parent directory, so started from src/ it built the binary and passed the unit tests, then bash exited 127 with "No such file or directory" for both scripts and the test step failed, in a plain checkout as in zig-common's CI layout. The scripts find everything else from their own path, so both steps now run in the build root wherever zig build was started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both steps run their script by a path relative to the working
directory, tests/test_eb_keep_logs.sh and tests/differential.sh, and a
Run step without a cwd runs where zig build was started. zig build
finds build.zig in a parent directory, so started from src/ it built
the binary and passed the unit tests, then bash exited 127 with "No
such file or directory" for both scripts and the test step failed, in
a plain checkout as in zig-common's CI layout. The scripts find
everything else from their own path, so both steps now run in the
build root wherever zig build was started.