Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ EXIF, camera and map playgrounds are separate packages. Flutter links every plug

| Case | Decided behavior |
|---|---|
| `DevToolsGate.enabled` read at runtime from a non-const place | It can't be: it's a `static const`. A wrapper that isn't `const` would defeat tree-shaking, so code review and the CI check both catch it. |
| `DevToolsGate.enabled` read at runtime from a non-const place | It can't be: it's a `static const`. A `static final` in its place defeats tree-shaking in the AOT builds (Android, iOS), and the CI check catches it there. The web compilers still fold it, so web builds stay clean. |
| The app forgets `--dart-define=SINEW_FLAVOR` in a staging release | Devtools are off. A forgotten setting fails safe. |
| The app's `MaterialApp` theme | The dashboard has its own `Theme`, so the app's theme never affects it. |

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Sinew's tests run in `commonTest` wherever possible, and on each platform where
| `android-device` | ubuntu + emulator (`android-emulator-runner`, API 35 `google_apis`, KVM) | instrumented tests: `FieldCipher` on the Keystore and a lost master key, `SecureStore` and Android's SQLite errors, the network checker switching Wi-Fi and data. The biometric tests skip themselves there and run through `tool/android-biometric-test.sh` |
| `ios` | macos | `./gradlew iosSimulatorArm64Test`, plus the Keychain, CryptoKit and biometric tests on a simulator, plus (from S5) an `xcodebuild` of the iOS sample |
| `web` | ubuntu | `./gradlew wasmJsBrowserTest` in headless Chrome |
| `devtools-gating` | ubuntu + macos | builds the production variants and fails if any non-no-op `com.srctool.sinew.devtools` class is present, and checks that the merged real ABI dumps equal the no-op dump (APK via `apkanalyzer`, the iOS framework via `nm`, desktop and web bundles by class and symbol listing) |
| `devtools-gating` | ubuntu (Android, desktop, web) + macos (iOS) | `checkDevToolsGating` builds the sample's production outputs (the Android production release APK, the desktop uber jar, the wasm production bundle, the `iosArm64` release framework) and fails if any holds a `com.srctool.sinew.devtools` declaration the no-op doesn't declare. The real-devtools outputs (the Android staging release, and the rest with `-Psinew.devtools=true`) are checked the opposite way. The ABI parity of the no-op is `checkDevtoolsNoopAbi`, in `jvm-android` |
| `publish` | macos, on tags | see [Publishing](/guide/delivery/publishing) |

| Rule | Why |
Expand All @@ -33,7 +33,7 @@ Sinew's tests run in `commonTest` wherever possible, and on each platform where

## 3. API {#kotlin-3-api}

Gradle tasks CI calls: `check`, `checkKotlinAbi`, `checkSinewGraph`, `koverVerify`, `iosSimulatorArm64Test`, `wasmJsBrowserTest`, `checkDevToolsGating` (a custom task wrapping the artifact checks), `publishAndReleaseToMavenCentral`.
Gradle tasks CI calls: `check`, `checkKotlinAbi`, `checkSinewGraph`, `koverVerify`, `iosSimulatorArm64Test`, `wasmJsBrowserTest`, `checkDevtoolsNoopAbi`, `checkDevToolsGating` (wrapping `checkDevToolsGatingAndroid`, `…Desktop`, `…Web`, and on macOS `…Ios`), `publishAndReleaseToMavenCentral`.

## 4. Build steps {#kotlin-4-build-steps}

Expand Down Expand Up @@ -76,7 +76,7 @@ CI has to run the pure-Dart tests on the VM and in Chrome, the Flutter tests, th
| `android` | ubuntu + emulator | `integration_test` for `sinew_security` (biometrics, Keystore), `sinew_storage`, the network checker |
| `ios` | macos | the same integration tests on a simulator, plus an iOS build of the example |
| `desktop` | macos, windows, ubuntu | builds the example; secure storage smoke tests per OS |
| `devtools-gating` | ubuntu + macos | production release **and profile** builds for Android, iOS and web, failing if the devtools marker string appears in the compiled output; a staging build must contain it |
| `devtools-gating` | ubuntu (Android, web JS, web Wasm) + macos-26 (iOS), one job per target | `tool/devtools_gating.sh` for production release **and profile** builds, failing if the devtools marker string appears in the compiled output; a staging release build must contain it |
| `publish` | ubuntu, on tags | see [Publishing](/guide/delivery/publishing) |

| Rule | Why |
Expand Down
Loading