Skip to content

feat(graph): the graph screen (G1 Task 13) - #147

Merged
dwikiriyadi merged 4 commits into
mainfrom
feat/g1-task13-graph-screen
Nov 17, 2026
Merged

dwikiriyadi merged 4 commits into
mainfrom
feat/g1-task13-graph-screen

Conversation

@dwikiriyadi

Copy link
Copy Markdown
Member

G1 Task 13: the real graph screen (S4's center) replaces the G0 spike. It follows the wireframe in plans/G1.md.

Screen

  • Bar: branch filter (all, current, or "{n} selected" from solo), Hide remotes, First parent, and an author filter that dims rather than hides. Search covers message, author, path or content, and matches a hash prefix at once. It shows "3 of 12", with Enter / Shift+Enter to step and Esc to clear.
  • Table: ref chips (two, then +n), GraphCanvas lanes over the laid-out rows with no edge copies, a WIP row joined to HEAD, author initials and the bot and AI marks, relative dates with the exact time in a tooltip, and the short SHA. Columns are resizable and hideable, and saved per repository.
  • States: skeleton after 300 ms, empty repository, filtered to nothing ("Show all branches"), git errors (Retry, Show output, code shown) kept above any rows already loaded, and the status line.
  • Keyboard and screen readers per Accessibility, "Graph": ↑/↓, PageUp/PageDown, Home/End, Alt+↓/↑/→, [/], Enter, Mod+C, Mod+F, Mod+Alt+Home, and speed search. Each row is read as one sentence.
  • D8: after a slow load (5 s or 100k rows) with no commit-graph file, the screen offers to write one, once per repository. The write goes through the session's write queue.
  • When refs move, the graph reloads and the selected commit stays selected.

Below the screen

  • Data:
    • log(…, firstParent).
    • RepositorySummary.changedFiles: a rename counts once.
    • CommitRepository.hasCommitGraph / writeCommitGraph.
    • ADR-27 (accepted): the graph's view choices and column widths in state.json v1 as optional fields. A fixture pins that a pre-ADR file still reads.
  • CommandOutput in :module:core:exception, implemented by GitException. The page shows git's output without depending on :module:core:git.
  • Removed: the spike, its benchmark package and GraphLanes. :app:desktop opens the graph for GRAFT_REPO until Task 20.

GitNexus rates the change CRITICAL (323 flows). The cause is that GitException, thrown by every git call, now implements CommandOutput. It adds no behavior: the members already existed.

Measurements on the 1.5M-commit Linux clone G0 used. Full numbers and method are in plans/progress.md.

This screen G0 spike
First screen 2.06 s 1.26–1.32 s, warm
Full load 32.7 s 21–31 s
Heap after full load 696 MB 677 MB
  • D10: HEAD's history alone reaches its first 60 commits in 26 ms, against 1.2–2.7 s for every ref. Whether to build HEAD-first loading is left for the author.

Tests:

  • Data, domain, view model (14), logic and page (labels, keys).
  • 9 screenshots. The Linux goldens come from this PR's first CI run, as before.
  • ./gradlew check passes on macOS.

Closes #18

🤖 Generated with Claude Code

dwikiriyadi and others added 4 commits November 16, 2026 14:01
The real graph screen replaces the G0 spike. It has a bar with branch,
remote, first-parent and author filters, and search with match
navigation. The table uses ref chips, GraphCanvas lanes, a WIP row,
author initials, relative dates and saved column widths. It handles
the loading, empty, filtered-to-nothing and git-error states (Retry
and Show output). It follows Accessibility's keyboard path, and each
row is read as one sentence.

- Data: first-parent log, changed-file count in the status summary,
  and the commit-graph check and write. ADR-27 adds the graph's view
  choices and column widths to state.json v1.
- CommandOutput in core:exception, so screens can show git's output
  without depending on core:git.
- D8's commit-graph offer, and a manual measurement test that repeats
  G0's numbers on the real screen and D10's HEAD-first timing.

Closes #18

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Dwiki Riyadi <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Dwiki Riyadi <[email protected]>
The Windows check job hung until it was cancelled (55 min, no log
kept), once on main after Task 10 and again on this branch. JUnit's
2-minute limit didn't catch it. Each test's limit now runs on a
separate thread, so a test that ignores interrupts still fails by
name. Each test task also stops after 15 minutes, so a JVM that never
exits fails its task, the job goes on, and the reports are uploaded.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Dwiki Riyadi <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Dwiki Riyadi <[email protected]>
@dwikiriyadi
dwikiriyadi merged commit d39962b into main Nov 17, 2026
6 checks passed
@dwikiriyadi
dwikiriyadi deleted the feat/g1-task13-graph-screen branch November 17, 2026 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

:module:feature:graph: the graph screen

1 participant