Repository navigation
feat(core-ui): desktop components on Camouflage tokens - #145
Merged
Merged
Conversation
A split pane, a dock layout with tool windows and edge stripes, document tabs, speed search, desktop scrollbars, resizable and hideable table columns, and the command palette shell, each shaped like its Camouflage proposal (camouflage#71-#76, #78) so it can be swapped when that ships. Keyboard tests for focus order, typing and tab switching, and a screenshot per component and state. Closes #132 Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Dwiki Riyadi <[email protected]>
Six goldens from the check (ubuntu-latest) job's renders, checked against the macOS ones. The dock's light and dark screenshots become two tests: in one loop, the missing light golden stopped the dark one from ever rendering. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Dwiki Riyadi <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Dwiki Riyadi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G1 Task 11 (closes #132).
What
:module:core:uicomponents. Each is shaped like its Camouflage proposal so the Camouflage version can replace it when that ships.SplitPane(camouflage#71): an app-ownedSplitPaneState, a 1 px divider line on a 7 px drag target, arrow keys (Shift for bigger steps), Enter to collapse, double-click to reset, and a value and range for screen readers.DockLayout(camouflage#75): left, right and bottom docks with edge stripes, one tool window open per dock, moving a window between docks, hiding, focus mode,toggleSideforCmd/Alt+1/2/3, Esc back to the center, and a snapshot to save the layout.DocumentTabs(camouflage#74): line tabs, a close button, middle-click close, a modified dot, pinned tabs, drag and keyboard reorder, a list-all menu on overflow, and a context-menu hook.Alt+←/→, hide and show from a right-click menu, one fill column, and snapshot/restore.CommandPalette(camouflage#76): grouped results with loading rows, keyboard navigation, shortcut hints and match highlighting.Tests
./gradlew checkpasses.Expected first CI result
As in Task 10, the 7 new screenshots have no Linux goldens yet. The ubuntu jobs will fail on those images only, and their renders get committed after a look.
Rulings (in
plans/progress.md)🤖 Generated with Claude Code