Skip to content

feat(core-ui): the Graft theme on Camouflage's Carbon skin - #144

Merged
dwikiriyadi merged 3 commits into
mainfrom
feat/g1-task10-theme
Nov 16, 2026
Merged

dwikiriyadi merged 3 commits into
mainfrom
feat/g1-task10-theme

Conversation

@dwikiriyadi

Copy link
Copy Markdown
Member

G1 Task 10 (closes #11).

What

:module:core:ui takes its first Camouflage dependency: camouflage-core and camouflage-skin-carbon 0.1.0, plus sinew-l10n 1.1.0.

  • GraftTheme: CamouflageProvider with the Carbon skin and graftTheme(mode).
    • Carbon's type, square shapes and motion, in IBM Plex Sans.
    • Atom One colors as Camouflage's color roles: Graft Light, Graft Dark, High contrast, and System following the OS.
    • Every theme passes Camouflage's theme validator.
  • Tokens:
    • GraftDensity, Standard and Comfortable.
    • The 8-color lane palette, each color at least 3:1 on its theme's background.
    • The 13 px dense text step, and a code style in JetBrains Mono.
  • Localizer: GraftLocalizer has English and Indonesian texts for every message key in the code, and is consulted before Sinew's own strings.
  • Assets (the downloads were approved):
    • IBM Plex Sans and JetBrains Mono, both OFL-1.1.
    • 41 Carbon icons (@carbon/icons 11.92.0, Apache-2.0) and a drawn stash icon.
    • Their licenses are in resources and in NOTICE.
  • Screenshots: Roborazzi 1.79.0, compared on Linux only. -PupdateGoldens re-records. CI now uploads build/outputs/roborazzi when the check fails.

Expected first CI result

There are no goldens yet, because they're recorded on Linux only and this machine has no Docker. So check (ubuntu-latest) will fail on the 3 missing reference-panel images, and its artifact will contain the Linux renders. I'll commit those after a look.

Tests

  • 8 theme tests and 3 screenshot tests. The screenshots were checked by eye on macOS.
  • ./gradlew check passes locally.

Rulings (in plans/progress.md)

  • The density is applied on Graft's side, because Camouflage 0.1.0 fixes controls at 48 px. This was the author's call, and it lasts until camouflage#70 ships.
  • CI records the first goldens.
  • Roborazzi is used as a library, not through its Gradle plugin.
  • Texts are properties files, because Compose resources generate code.
  • The Atom One colors are adjusted where the published ones fail AA.
  • High contrast is a fixed palette until Settings (Task 18).
  • There's no compact preset, because no setting exists for it.

🤖 Generated with Claude Code

dwikiriyadi and others added 3 commits November 16, 2026 06:25
Graft Light, Graft Dark and High contrast as Camouflage color roles
from Atom's One themes, each passing Camouflage's theme validator.
IBM Plex Sans and JetBrains Mono bundled, the Carbon icons G1 uses
plus a drawn stash icon, Graft's density and lane tokens, and the
localizer with English and Indonesian texts. Roborazzi screenshot
tests of a reference panel, compared on Linux only.

Closes #11

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Dwiki Riyadi <[email protected]>
Gradle refuses a directory input that doesn't exist, even optional, and
git doesn't keep the empty folder, so every CI job failed before the
tests ran. Declare the goldens as a file tree instead.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Dwiki Riyadi <[email protected]>
Rendered by the check (ubuntu-latest) job of PR #144, checked by eye
against the macOS renders.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Dwiki Riyadi <[email protected]>
@dwikiriyadi
dwikiriyadi merged commit 4d71531 into main Nov 16, 2026
6 checks passed
@dwikiriyadi
dwikiriyadi deleted the feat/g1-task10-theme branch November 16, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

:module:core:ui: Carbon theme in Atom One colors

1 participant