Repository navigation
feat(core-ui): the Graft theme on Camouflage's Carbon skin - #144
Merged
Merged
Conversation
Graft Light, Graft Dark and High contrast as Camouflage color roles from Atom's One themes, each passing Camouflage's theme validator. IBM Plex Sans and JetBrains Mono bundled, the Carbon icons G1 uses plus a drawn stash icon, Graft's density and lane tokens, and the localizer with English and Indonesian texts. Roborazzi screenshot tests of a reference panel, compared on Linux only. Closes #11 Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Dwiki Riyadi <[email protected]>
Gradle refuses a directory input that doesn't exist, even optional, and git doesn't keep the empty folder, so every CI job failed before the tests ran. Declare the goldens as a file tree instead. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Dwiki Riyadi <[email protected]>
Rendered by the check (ubuntu-latest) job of PR #144, checked by eye against the macOS renders. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Dwiki Riyadi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G1 Task 10 (closes #11).
What
:module:core:uitakes its first Camouflage dependency:camouflage-coreandcamouflage-skin-carbon0.1.0, plussinew-l10n1.1.0.GraftTheme:CamouflageProviderwith the Carbon skin andgraftTheme(mode).GraftDensity, Standard and Comfortable.GraftLocalizerhas English and Indonesian texts for every message key in the code, and is consulted before Sinew's own strings.@carbon/icons11.92.0, Apache-2.0) and a drawn stash icon.-PupdateGoldensre-records. CI now uploadsbuild/outputs/roborazziwhen the check fails.Expected first CI result
There are no goldens yet, because they're recorded on Linux only and this machine has no Docker. So
check (ubuntu-latest)will fail on the 3 missing reference-panel images, and its artifact will contain the Linux renders. I'll commit those after a look.Tests
./gradlew checkpasses locally.Rulings (in
plans/progress.md)🤖 Generated with Claude Code