Repository navigation
feat(feature-domain): use cases for Home and the graph - #142
Merged
Merged
Conversation
Home: open a folder (root, subfolder, missing, not a repository, untrusted with the exact safe.directory change shown first), scan a folder, clone and init, each recorded in the recent list. Graph: hide and solo refs, search highlighted in the full graph, hash and author-type matching, the compare summary, and the reflog timeline merged across HEAD and every branch. The data layer gains LogScope for log and search, and untrustedFolder for the dubious-ownership path. Closes #131 Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Dwiki Riyadi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G1 Task 8 (closes #131).
What
:module:feature:homedomainOpenRepositoryUseCase.open(folder)returns one of:Opened: the root (the working tree, or a bare repository's git folder) plus the subfolder pointed at. It's recorded in the recent list by real path.FolderMissingNotARepository: Home offers Init or Clone.Untrusted: git's own spelling of the folder, and the exactgit config --global --add safe.directory <path>to show.FailedtrustAndOpenwritessafe.directoryonly after that's been shown, then opens the folder again.ScanFolderUseCase: found repositories, marked when Home already lists them, optionally made into a workspace.CloneRepositoryUseCaseandInitRepositoryUseCaserecord the new repository.:module:feature:graphdomainGraphFilter: hidden and solo refs, turned into aLogScope.prunedTodrops refs that no longer exist.LoadGraphUseCase.load(repository, filter).SearchGraphUseCase: matching commit ids in batches, to highlight in the full graph (the author's choice).GraphMatch: hash-prefix and author-type matching.CompareSummaryUseCase: ahead, behind and the merge base.ReflogTimelineUseCase: HEAD's reflog and every local branch's, merged newest first and paged. A move logged in several reflogs appears once with all its refs. Every entry's source isGITuntil G2's op log.:module:data:git(approved additions after the data-layer review)LogScope.All(hidden)/LogScope.Only(refs)forCommitRepository.logandsearch. Only full ref names reach git; solo refs follow--end-of-options.RepositoryAccessRepository.untrustedFolder(error), because features can't import:module:core:git's exception type.Tests
untrustedFoldercheck, on real git../gradlew checkpasses on Git 2.54. Git 2.38 runs ingit-min.Notes for review
untrustedFolderwith steps it has nothing to do with.GitRunner. With the default scope, git gets the same arguments as before.plans/progress.md.🤖 Generated with Claude Code